Closed Bug 1426462 Opened 2 years ago Closed 2 years ago

Update Debugger Frontend (12-20)

Categories

(DevTools :: Debugger, enhancement, P3)

57 Branch
enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

()

Details

Attachments

(1 file, 10 obsolete files)

No description provided.
Attached patch patch-12-20-1.patch (obsolete) — Splinter Review
Attachment #8938094 - Flags: review?(jdescottes)
Attachment #8938094 - Attachment is obsolete: true
Attachment #8938094 - Flags: review?(jdescottes)
Attached patch patch-12-20-2.patch (obsolete) — Splinter Review
Attachment #8938097 - Flags: review?(jdescottes)
Attachment #8938097 - Attachment is obsolete: true
Attachment #8938097 - Flags: review?(jdescottes)
Attached patch patch-12-20-3.patch (obsolete) — Splinter Review
Attachment #8938101 - Flags: review?(jdescottes)
Attachment #8938101 - Attachment is obsolete: true
Attachment #8938101 - Flags: review?(jdescottes)
Attached patch patch-12-20-4.patch (obsolete) — Splinter Review
Attachment #8938103 - Flags: review?(jdescottes)
Attachment #8938103 - Attachment is obsolete: true
Attachment #8938103 - Flags: review?(jdescottes)
Attached patch patch-12-20-8.patch (obsolete) — Splinter Review
Attachment #8938109 - Flags: review?(jdescottes)
Assignee: nobody → jlaster
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #8938109 - Attachment is obsolete: true
Attachment #8938109 - Flags: review?(jdescottes)
Attached patch patch-12-20-9.patch (obsolete) — Splinter Review
Attachment #8938112 - Flags: review?(jdescottes)
i think this patch can be much smaller. Will look into that before it lands
(In reply to Jason Laster [:jlast] from comment #9)
> i think this patch can be much smaller. Will look into that before it lands

In that case, tag me for review when ready :)
Attachment #8938112 - Flags: review?(jdescottes)
Comment on attachment 8938112 [details] [diff] [review]
patch-12-20-9.patch

This is actually the correct bundle... Sorry for the confusion
Attachment #8938112 - Flags: review?(jdescottes)
http://g.recordit.co/1PcFJrqefI.gif

^ this bundle is much faster than the previous bundle
Attachment #8938112 - Attachment is obsolete: true
Attachment #8938112 - Flags: review?(jdescottes)
Attached patch patch-12-20-10.patch (obsolete) — Splinter Review
Attachment #8938187 - Flags: review?(jdescottes)
Comment on attachment 8938187 [details] [diff] [review]
patch-12-20-10.patch

Review of attachment 8938187 [details] [diff] [review]:
-----------------------------------------------------------------

Try is orange, waiting for a green try before reviewing.
Attachment #8938187 - Flags: review?(jdescottes) → review-
With the process we discussed in Austin, we should do the bisect + try runs before creating the release. Let's stick to that please :)
Attachment #8938187 - Attachment is obsolete: true
Attached patch patch-12-20-12.patch (obsolete) — Splinter Review
Attachment #8938340 - Flags: review?(jdescottes)
Attachment #8938340 - Attachment is obsolete: true
Attachment #8938340 - Flags: review?(jdescottes)
Attached patch patch-12-21-15.patch (obsolete) — Splinter Review
Attachment #8938469 - Flags: review?(jdescottes)
Attached patch 12-20-15.patch (obsolete) — Splinter Review
Attachment #8938469 - Attachment is obsolete: true
Attachment #8938469 - Flags: review?(jdescottes)
Attachment #8938484 - Flags: review?(jdescottes)
Attached patch 12-20-16.patchSplinter Review
Attachment #8938484 - Attachment is obsolete: true
Attachment #8938484 - Flags: review?(jdescottes)
Attachment #8938527 - Flags: review?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/143a3674f127
Update Debugger Frontend (12-20). r=jdescottes
Attachment #8938527 - Flags: review?(jdescottes) → review+
https://hg.mozilla.org/mozilla-central/rev/143a3674f127
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.