Closed
Bug 1426462
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend (12-20)
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
()
Details
Attachments
(1 file, 10 obsolete files)
691.63 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8938094 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8938094 -
Attachment is obsolete: true
Attachment #8938094 -
Flags: review?(jdescottes)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8938097 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8938097 -
Attachment is obsolete: true
Attachment #8938097 -
Flags: review?(jdescottes)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8938101 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8938101 -
Attachment is obsolete: true
Attachment #8938101 -
Flags: review?(jdescottes)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8938103 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8938103 -
Attachment is obsolete: true
Attachment #8938103 -
Flags: review?(jdescottes)
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8938109 -
Flags: review?(jdescottes)
Updated•7 years ago
|
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Attachment #8938109 -
Attachment is obsolete: true
Attachment #8938109 -
Flags: review?(jdescottes)
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8938112 -
Flags: review?(jdescottes)
Assignee | ||
Comment 9•7 years ago
|
||
i think this patch can be much smaller. Will look into that before it lands
Comment 10•7 years ago
|
||
(In reply to Jason Laster [:jlast] from comment #9)
> i think this patch can be much smaller. Will look into that before it lands
In that case, tag me for review when ready :)
Updated•7 years ago
|
Attachment #8938112 -
Flags: review?(jdescottes)
Assignee | ||
Comment 11•7 years ago
|
||
Comment on attachment 8938112 [details] [diff] [review]
patch-12-20-9.patch
This is actually the correct bundle... Sorry for the confusion
Attachment #8938112 -
Flags: review?(jdescottes)
Assignee | ||
Comment 12•7 years ago
|
||
http://g.recordit.co/1PcFJrqefI.gif
^ this bundle is much faster than the previous bundle
Assignee | ||
Comment 13•7 years ago
|
||
Assignee | ||
Comment 14•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8938112 -
Attachment is obsolete: true
Attachment #8938112 -
Flags: review?(jdescottes)
Assignee | ||
Comment 15•7 years ago
|
||
Attachment #8938187 -
Flags: review?(jdescottes)
Comment 16•7 years ago
|
||
(In reply to Jason Laster [:jlast] from comment #12)
> http://g.recordit.co/1PcFJrqefI.gif
>
> ^ this bundle is much faster than the previous bundle
403 access denied
(In reply to Jason Laster [:jlast] from comment #14)
> https://treeherder
Broken links?
I suppose the last try pushes are
- https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7d53403ea8ec40721bcde66b40cc3c5c9ca0931
- https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dcab0dfd181fbe85821db61f3c51350a664f72a
Which are very much orange.
Here is the compare list for the release: https://github.com/devtools-html/debugger.html/compare/53faca589b021f01c7af5980c8c0e98b58c02e4c...ff798e10513e007a40f3014dca26279951afbc0d
Comment 17•7 years ago
|
||
Comment on attachment 8938187 [details] [diff] [review]
patch-12-20-10.patch
Review of attachment 8938187 [details] [diff] [review]:
-----------------------------------------------------------------
Try is orange, waiting for a green try before reviewing.
Attachment #8938187 -
Flags: review?(jdescottes) → review-
Comment 18•7 years ago
|
||
With the process we discussed in Austin, we should do the bisect + try runs before creating the release. Let's stick to that please :)
Assignee | ||
Comment 19•7 years ago
|
||
Assignee | ||
Comment 20•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8938187 -
Attachment is obsolete: true
Assignee | ||
Comment 21•7 years ago
|
||
Attachment #8938340 -
Flags: review?(jdescottes)
Assignee | ||
Comment 22•7 years ago
|
||
Assignee | ||
Comment 23•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8938340 -
Attachment is obsolete: true
Attachment #8938340 -
Flags: review?(jdescottes)
Assignee | ||
Comment 24•7 years ago
|
||
Attachment #8938469 -
Flags: review?(jdescottes)
Assignee | ||
Comment 25•7 years ago
|
||
Attachment #8938469 -
Attachment is obsolete: true
Attachment #8938469 -
Flags: review?(jdescottes)
Attachment #8938484 -
Flags: review?(jdescottes)
Assignee | ||
Comment 26•7 years ago
|
||
Assignee | ||
Comment 27•7 years ago
|
||
Attachment #8938484 -
Attachment is obsolete: true
Attachment #8938484 -
Flags: review?(jdescottes)
Attachment #8938527 -
Flags: review?(jdescottes)
Assignee | ||
Comment 28•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b1c9606fed2708fb1c8ae04ed5499542235bcd1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e75581cf6f44428d5f579d51ef7a03a129be3c48
https://treeherder.mozilla.org/#/jobs?repo=try&revision=608c4cc0f79b77f695ba0d108fe2ab67a9792744
I could not run the repeats because, i think try is afraid i'm ddosing them...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d766a523ce3c7ad1c2a7a2962330fa11dd9627e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=466fc0eb882a09c29d56a8ba734c9501bf56b9e1
Assignee | ||
Comment 29•7 years ago
|
||
Comment 30•7 years ago
|
||
Commits included in the release (would be nice to have this in the bug by default) :
https://github.com/devtools-html/debugger.html/compare/53faca589b021f01c7af5980c8c0e98b58c02e4c...4942cf4fd6914ba5ea577967b4835615b5accb34
Comment 31•7 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/143a3674f127
Update Debugger Frontend (12-20). r=jdescottes
Updated•7 years ago
|
Attachment #8938527 -
Flags: review?(jdescottes) → review+
Comment 32•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•