Optimize QuerySelector / GetElementById inside shadow trees.

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

We have optimizations for GetElementById and querySelector with id selectors for nodes in the document, we should be able  to do the same for nodes in a shadow root.
Assignee

Updated

a year ago
Depends on: 1426494
Priority: -- → P1
Assignee

Updated

a year ago
Depends on: 1427001
Priority: P1 → P3
Do we need this for shipping Shadow DOM for the first time? (otherwise I'd like to make it block bug 1438607 instead)
Flags: needinfo?(emilio)
Sounds nice to have and shouldn't be _too_ much work, but yeah, let's move it, doesn't need to block.
Flags: needinfo?(emilio)
Blocks: shadowdom
No longer blocks: shadowdom-layout
Assignee

Updated

a year ago
Depends on: 1464428
Assignee

Updated

a year ago
Depends on: 1464433
Assignee

Updated

a year ago
No longer depends on: 1464433
Assignee

Comment 3

6 months ago
There's only one missing bit here.
Assignee: nobody → emilio
Assignee

Comment 4

6 months ago
This is the only optimization missing compared to documents.

Comment 5

6 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/aa84fe3c5853
Optimize Element.getElementById inside shadow trees. r=bzbarsky

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aa84fe3c5853
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.