Closed Bug 1426493 Opened 6 years ago Closed 5 years ago

Optimize QuerySelector / GetElementById inside shadow trees.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We have optimizations for GetElementById and querySelector with id selectors for nodes in the document, we should be able  to do the same for nodes in a shadow root.
Depends on: 1426494
Priority: -- → P1
Depends on: 1427001
Priority: P1 → P3
Do we need this for shipping Shadow DOM for the first time? (otherwise I'd like to make it block bug 1438607 instead)
Flags: needinfo?(emilio)
Sounds nice to have and shouldn't be _too_ much work, but yeah, let's move it, doesn't need to block.
Flags: needinfo?(emilio)
Blocks: shadowdom
No longer blocks: shadowdom-layout
Depends on: 1464428
Depends on: 1464433
No longer depends on: 1464433
There's only one missing bit here.
Assignee: nobody → emilio
This is the only optimization missing compared to documents.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/aa84fe3c5853
Optimize Element.getElementById inside shadow trees. r=bzbarsky
https://hg.mozilla.org/mozilla-central/rev/aa84fe3c5853
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.