Closed Bug 1426513 Opened 2 years ago Closed 2 years ago

Remove ProcessMetrics, ProcessFilter and SysInfo

Categories

(Core :: IPC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

More dead code identified in part by the code coverage at: https://marco-c.github.io/code-coverage-reports/#ipc
Additionally, the CPU class is only used by TimeTicks::HighResNow(), but that is unused, so remove it.
Comment on attachment 8938387 [details]
Bug 1426513, part 1 - Remove ProcessMetrics and ProcessFilter.

https://reviewboard.mozilla.org/r/209088/#review214922
Attachment #8938387 - Flags: review?(jld) → review+
Comment on attachment 8938389 [details]
Bug 1426513, part 3 - Remove CPU and TimeTicks::HighResNow.

https://reviewboard.mozilla.org/r/209092/#review214926
Attachment #8938389 - Flags: review?(jld) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d80a554866c
part 1 - Remove ProcessMetrics and ProcessFilter. r=jld
https://hg.mozilla.org/integration/autoland/rev/64021383118d
part 2 - Remove SysInfo. r=jld
https://hg.mozilla.org/integration/autoland/rev/693bb500fc25
part 3 - Remove CPU and TimeTicks::HighResNow. r=jld
Oops. I have warnings disabled locally so I can use ICECC, and my try push was on Windows. I guess I should have done Linux, too.
Building locally on Mac, I notice that I forgot to remove the implementation of the high rest time function on OSX. I'll fix that, too.
Flags: needinfo?(continuation)
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d5cf07bbab1
part 1 - Remove ProcessMetrics and ProcessFilter. r=jld
https://hg.mozilla.org/integration/autoland/rev/d491c1d3bc84
part 2 - Remove SysInfo. r=jld
https://hg.mozilla.org/integration/autoland/rev/f0c1a3d57efc
part 3 - Remove CPU and TimeTicks::HighResNow. r=jld
You need to log in before you can comment on or make changes to this bug.