1426513 - Remove ProcessMetrics, ProcessFilter and SysInfo

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Andrew McCreight [:mccr8]]

More dead code identified in part by the code coverage at: https://marco-c.github.io/code-coverage-reports/#ipc

Comment 1

[Andrew McCreight [:mccr8]]

Additionally, the CPU class is only used by TimeTicks::HighResNow(), but that is unused, so remove it.

Comment 2

[Andrew McCreight [:mccr8]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae50db7725982dfa4c41f444107ba36186d6129e

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1426513, part 1 - Remove ProcessMetrics and ProcessFilter.

Review commit: https://reviewboard.mozilla.org/r/209088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209088/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1426513, part 2 - Remove SysInfo.

Review commit: https://reviewboard.mozilla.org/r/209090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209090/

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1426513, part 3 - Remove CPU and TimeTicks::HighResNow.

CPU is only used on Windows, for TimeTicks::HighResNow, but the latter
is not used, so remove them all.

Review commit: https://reviewboard.mozilla.org/r/209092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209092/

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8938387 [details]
Bug 1426513, part 1 - Remove ProcessMetrics and ProcessFilter.

https://reviewboard.mozilla.org/r/209088/#review214922

Comment 7

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8938388 [details]
Bug 1426513, part 2 - Remove SysInfo.

https://reviewboard.mozilla.org/r/209090/#review214924

Comment 8

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8938389 [details]
Bug 1426513, part 3 - Remove CPU and TimeTicks::HighResNow.

https://reviewboard.mozilla.org/r/209092/#review214926

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d80a554866c
part 1 - Remove ProcessMetrics and ProcessFilter. r=jld
https://hg.mozilla.org/integration/autoland/rev/64021383118d
part 2 - Remove SysInfo. r=jld
https://hg.mozilla.org/integration/autoland/rev/693bb500fc25
part 3 - Remove CPU and TimeTicks::HighResNow. r=jld

Comment 10

[Cristina Coroiu [:ccoroiu]]

Backed out 3 changesets (bug 1426513) for bustage at /src/base/process_util_posix.cc r=backout on a CLOSED TREE

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=693bb500fc2531d3411dc508dac86ac04af2072f 

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152960154&repo=autoland&lineNumber=11000

Backout: https://hg.mozilla.org/integration/autoland/rev/8a45850ffc2ed66f66b9417fd34ed4d0561273fc

Comment 11

[Andrew McCreight [:mccr8]]

Oops. I have warnings disabled locally so I can use ICECC, and my try push was on Windows. I guess I should have done Linux, too.

Comment 12

[Andrew McCreight [:mccr8]]

Building locally on Mac, I notice that I forgot to remove the implementation of the high rest time function on OSX. I'll fix that, too.

Comment 13

[Andrew McCreight [:mccr8]]

Comment on attachment 8938387 [details]
Bug 1426513, part 1 - Remove ProcessMetrics and ProcessFilter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209088/diff/1-2/

Comment 14

[Andrew McCreight [:mccr8]]

Comment on attachment 8938388 [details]
Bug 1426513, part 2 - Remove SysInfo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209090/diff/1-2/

Comment 15

[Andrew McCreight [:mccr8]]

Comment on attachment 8938389 [details]
Bug 1426513, part 3 - Remove CPU and TimeTicks::HighResNow.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209092/diff/1-2/

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d5cf07bbab1
part 1 - Remove ProcessMetrics and ProcessFilter. r=jld
https://hg.mozilla.org/integration/autoland/rev/d491c1d3bc84
part 2 - Remove SysInfo. r=jld
https://hg.mozilla.org/integration/autoland/rev/f0c1a3d57efc
part 3 - Remove CPU and TimeTicks::HighResNow. r=jld

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9d5cf07bbab1
https://hg.mozilla.org/mozilla-central/rev/d491c1d3bc84
https://hg.mozilla.org/mozilla-central/rev/f0c1a3d57efc