Closed
Bug 1426513
Opened 6 years ago
Closed 6 years ago
Remove ProcessMetrics, ProcessFilter and SysInfo
Categories
(Core :: IPC, enhancement)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
More dead code identified in part by the code coverage at: https://marco-c.github.io/code-coverage-reports/#ipc
|
Assignee | |
Comment 1•6 years ago
|
||
Additionally, the CPU class is only used by TimeTicks::HighResNow(), but that is unused, so remove it.
|
||
Updated•6 years ago
|
Blocks: deadcode-codecoverage
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae50db7725982dfa4c41f444107ba36186d6129e
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938387 [details] Bug 1426513, part 1 - Remove ProcessMetrics and ProcessFilter. https://reviewboard.mozilla.org/r/209088/#review214922
Attachment #8938387 -
Flags: review?(jld) → review+
|
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938388 [details] Bug 1426513, part 2 - Remove SysInfo. https://reviewboard.mozilla.org/r/209090/#review214924
Attachment #8938388 -
Flags: review?(jld) → review+
|
|
||
Comment 8•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938389 [details] Bug 1426513, part 3 - Remove CPU and TimeTicks::HighResNow. https://reviewboard.mozilla.org/r/209092/#review214926
Attachment #8938389 -
Flags: review?(jld) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d80a554866c part 1 - Remove ProcessMetrics and ProcessFilter. r=jld https://hg.mozilla.org/integration/autoland/rev/64021383118d part 2 - Remove SysInfo. r=jld https://hg.mozilla.org/integration/autoland/rev/693bb500fc25 part 3 - Remove CPU and TimeTicks::HighResNow. r=jld
|
||
Comment 10•6 years ago
|
||
Backed out 3 changesets (bug 1426513) for bustage at /src/base/process_util_posix.cc r=backout on a CLOSED TREE Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=693bb500fc2531d3411dc508dac86ac04af2072f Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152960154&repo=autoland&lineNumber=11000 Backout: https://hg.mozilla.org/integration/autoland/rev/8a45850ffc2ed66f66b9417fd34ed4d0561273fc
Flags: needinfo?(continuation)
|
|
Assignee | |
Comment 11•6 years ago
|
||
Oops. I have warnings disabled locally so I can use ICECC, and my try push was on Windows. I guess I should have done Linux, too.
|
|
Assignee | |
Comment 12•6 years ago
|
||
Building locally on Mac, I notice that I forgot to remove the implementation of the high rest time function on OSX. I'll fix that, too.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(continuation)
|
||
Comment 16•6 years ago
|
||
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d5cf07bbab1 part 1 - Remove ProcessMetrics and ProcessFilter. r=jld https://hg.mozilla.org/integration/autoland/rev/d491c1d3bc84 part 2 - Remove SysInfo. r=jld https://hg.mozilla.org/integration/autoland/rev/f0c1a3d57efc part 3 - Remove CPU and TimeTicks::HighResNow. r=jld
|
||
Comment 17•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9d5cf07bbab1 https://hg.mozilla.org/mozilla-central/rev/d491c1d3bc84 https://hg.mozilla.org/mozilla-central/rev/f0c1a3d57efc
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•