Closed
Bug 1426520
Opened 8 years ago
Closed 8 years ago
Run webpack with --display-optimization-bailout
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: Mardak, Assigned: k88hudson)
References
Details
Followup comments from dmose from https://github.com/mozilla/activity-stream/pull/3910
reading https://medium.com/webpack/webpack-freelancing-log-book-week-5-7-4764be3266f5 has a bunch of interseting info, including one pattern that will generate bad code unless we disable part of the optimization. that's in the "other changes required" section.
"Don’t use this in exported functions, if you don’t .call them explicitly."
hmmm, maybe that's outdated, and that the optimization bailout code will fire instead of generating bad code: https://webpack.js.org/plugins/module-concatenation-plugin/#optimization-bailouts
also, eyeballing the generated code, some concatention is clearly going on, so that's a good thing
Updated•8 years ago
|
Assignee: nobody → khudson
Iteration: --- → 1.26
Priority: -- → P2
| Reporter | ||
Updated•8 years ago
|
Iteration: 1.26 → 59.4 - Jan 15
Comment 1•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/1374b5f26ff1e5931bd9d1e4ffc2ec293e2b37f4
feat(webpack): Add --display-optimization-bailout and use jsm-to-esmodules (#3932)
Fix Bug 1426520 - Run webpack with --display-optimization-bailout
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 2•8 years ago
|
||
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•