1426523 - All Windows builds are going to permafail when Gecko 59 merges to Beta on 2018-01-11

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing builds on the next merge day.

This is completely blocking my ability to get Windows test results on uplift simulations at the moment, so please consider this high priority.

https://treeherder.mozilla.org/logviewer.html#?job_id=152708930&repo=try

z:\build\build\src\obj-firefox\dist\include\mozilla/widget/PDFiumParent.h(9): fatal error C1083: Cannot open include file: 'mozilla/widget/PPDFiumParent.h': No such file or directory

Comment 1

[Daniel Holbert [:dholbert]]

I think PDFiumParent.h comes from PPDFium.ipdl, which is included in moz.config like this:
> if CONFIG['MOZ_ENABLE_SKIA_PDF']:
>     DIRS += ['/modules/pdfium']
>     IPDL_SOURCES += [
>         'PPDFium.ipdl',
>     ]
https://searchfox.org/mozilla-central/rev/f6f1731b1b7fec332f86b55fa40e2c9ae67ac39b/widget/windows/moz.build#105-108

...but its #include site in PrintTargetEMF.cpp has no such MOZ_ENABLE_SKIA_PDF guard:

#include "mozilla/widget/PDFiumParent.h"
> elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
>   [...]
>   UNIFIED_SOURCES += [
>        'D3D11Checks.cpp',
>        'DeviceManagerDx.cpp',
>        'PrintTargetEMF.cpp',
>   ]
https://searchfox.org/mozilla-central/rev/f6f1731b1b7fec332f86b55fa40e2c9ae67ac39b/gfx/thebes/moz.build#226


So (on Windows) we're unconditionally including a .h file that is only generated under some conditions. I'm guessing that might be the issue here?  (i.e. maybe MOZ_ENABLE_SKIA_PDF is off on beta?)

Comment 2

[Daniel Holbert [:dholbert]]

Yeah, looks like MOZ_ENABLE_SKIA_PDF might get turned on specifically for Nightly, so I think comment 1 is the issue. (See  "milestone.is_nightly" dependency here:
https://dxr.mozilla.org/mozilla-central/rev/1624b88874765bf57e9feba176d30149c748d9d2/toolkit/moz.configure#975,979-980,987
)

cku, would it make sense to adjust the latter moz.build quote from comment 1 so that PrintTargetEMF.cpp is only added to UNIFIED_SOURCES if MOZ_ENABLE_SKIA_PDF is enabled?  (Are there other similar changes that we need, too?)

For testing a hypothetical fix here, it looks like you'd want to apply these three patches (which RyanVM is using to trigger "nightly as beta" in that try run, on top of mozilla-central):
 https://hg.mozilla.org/try/rev/cbffda58df6a
 https://hg.mozilla.org/try/rev/13da3478df26
 https://hg.mozilla.org/try/rev/2f38d26cfa4c

Comment 3

[u459114]

I will fix it ASAP

Comment 4

[u459114]

Attachment: Patch

Comment 5

[u459114]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> For testing a hypothetical fix here, it looks like you'd want to apply these
> three patches (which RyanVM is using to trigger "nightly as beta" in that
> try run, on top of mozilla-central):
>  https://hg.mozilla.org/try/rev/cbffda58df6a
>  https://hg.mozilla.org/try/rev/13da3478df26
>  https://hg.mozilla.org/try/rev/2f38d26cfa4c

dholbert, Thanks for this detailed information

Comment 6

[u459114]

Attachment: Bug 1426523 - Add PrintTargetEMF.* only if MOZ_ENABLE_SKIA_PDF is enable.

Review commit: https://reviewboard.mozilla.org/r/209010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209010/

Comment 7

[u459114]

Comment on attachment 8938254 [details]
Bug 1426523 - Add PrintTargetEMF.* only if MOZ_ENABLE_SKIA_PDF is enable.

https://reviewboard.mozilla.org/r/209008/#review214708

Comment 8

[u459114]

Comment on attachment 8938254 [details]
Bug 1426523 - Add PrintTargetEMF.* only if MOZ_ENABLE_SKIA_PDF is enable.

https://reviewboard.mozilla.org/r/209008/#review214710

Fix a compile error on beta

Comment 9

[u459114]

Comment on attachment 8938254 [details]
Bug 1426523 - Add PrintTargetEMF.* only if MOZ_ENABLE_SKIA_PDF is enable.

https://reviewboard.mozilla.org/r/209010/#review214712

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63a089b7dc04
Add PrintTargetEMF.* only if MOZ_ENABLE_SKIA_PDF is enable. r=cjku

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/63a089b7dc04

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking as a blocker for the upcoming merge to beta.