1426543 - Consolidate some Treeherder platforms

Status: NEW

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

We have a number of "platforms" on Treeherder that only have 1 or 2 tasks. This is wasteful of UI real estate.

We consolidated "rusttests" platforms in bug 1426292. Let's continue that process here.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1426543 - Consolidate some MacOS Treeherder platforms;

We currently have separate Treeherder platforms for MacOS tasks. I
suspect these are a holdover from the days where we had "native" MacOS
builds and the new cross builds. We no longer have native MacOS
builds. And I don't see a valid reason to maintain separate "cross"
platforms for MacOS tasks for Treeherder display purposes.

This commit consolidates most MacOS build tasks to their "native"
platform. This will result in B* tasks appearing on the same line
as tests, which is how nearly every other platform works.

I didn't change a devedition platform because there are references
to the *-devedition platforms elsewhere and I didn't feel like
seeing where that rabbit hole would lead. Ditto for the Nightly
build configuration.

There are also a bunch of l10n and signing tasks on the "cross"
platforms. I /think/ we can defer dealing with these.

Review commit: https://reviewboard.mozilla.org/r/208936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208936/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1426543 - Consolidate "noopt" builds into existing platform;

These 3 builds are the only tasks on this one-off Treeherder
platform. This is wasteful of Treeherder real estate.

Move them into a more populous platform.

Review commit: https://reviewboard.mozilla.org/r/208938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208938/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8938197 [details]
Bug 1426543 - Consolidate "noopt" builds into existing platform;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208938/diff/1-2/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8938196 [details]
Bug 1426543 - Consolidate some MacOS Treeherder platforms;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208936/diff/1-2/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8938197 [details]
Bug 1426543 - Consolidate "noopt" builds into existing platform;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208938/diff/2-3/

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8938196 [details]
Bug 1426543 - Consolidate some MacOS Treeherder platforms;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208936/diff/2-3/

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8938197 [details]
Bug 1426543 - Consolidate "noopt" builds into existing platform;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208938/diff/3-4/

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8938196 [details]
Bug 1426543 - Consolidate some MacOS Treeherder platforms;

https://reviewboard.mozilla.org/r/208936/#review214882

::: commit-message-62dd5:7
(Diff revision 3)
> +
> +We currently have separate Treeherder platforms for MacOS tasks. I
> +suspect these are a holdover from the days where we had "native" MacOS
> +builds and the new cross builds. We no longer have native MacOS
> +builds. And I don't see a valid reason to maintain separate "cross"
> +platforms for MacOS tasks for Treeherder display purposes.

My understanding is that this came from the time when we had multiple OS X test platforms (for different versions) and a single build platform (yet another version).

::: taskcluster/ci/build/macosx.yml:7
(Diff revision 3)
>      description: "MacOS X x64 Cross-compile"
>      index:
>          product: firefox
>          job-name: macosx64-debug
>      treeherder:
> -        platform: osx-cross/debug
> +        platform: osx-10-10/debug

Are these "10-10" builds?  Is the SDK in use in the cross-compiles is specific to 10.10?  Would we want a new platform if we were to start cross-compiling in parallel on osx-10-13 or something?

Otherwise, perhaps better to just call these "osx/debug"?

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8938197 [details]
Bug 1426543 - Consolidate "noopt" builds into existing platform;

https://reviewboard.mozilla.org/r/208938/#review214886

..modulo the same concerns with osx-10-10.

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8938196 [details]
Bug 1426543 - Consolidate some MacOS Treeherder platforms;

https://reviewboard.mozilla.org/r/208936/#review215178

::: commit-message-62dd5:7
(Diff revision 3)
> +
> +We currently have separate Treeherder platforms for MacOS tasks. I
> +suspect these are a holdover from the days where we had "native" MacOS
> +builds and the new cross builds. We no longer have native MacOS
> +builds. And I don't see a valid reason to maintain separate "cross"
> +platforms for MacOS tasks for Treeherder display purposes.

Dustin is right. We had 10.7 tests and 10.10 tests, they were on separate platforms. And I think at some point, the builds were on 10.8 or 10.9, so they would even appear on a separate platform.

::: taskcluster/ci/build/macosx.yml:7
(Diff revision 3)
>      description: "MacOS X x64 Cross-compile"
>      index:
>          product: firefox
>          job-name: macosx64-debug
>      treeherder:
> -        platform: osx-cross/debug
> +        platform: osx-10-10/debug

As a matter of fact, the current SDK we use is 10.11. But we still default to 10.7 for MACOSX_DEPLOYMENT_TARGET (we should probably change that). If anything, the platform should reflect MACOSX_DEPLOYMENT_TARGET.

10.10 is just what we happen to run tests on at the moment.

With all that being said, builds are already hard enough to find in the sea of jobs on treeherder, I'm not particularly convinced that putting builds and tests on the same lines is useful in any way at this point.

Comment 11

[Mike Hommey [:glandium]]

Comment on attachment 8938197 [details]
Bug 1426543 - Consolidate "noopt" builds into existing platform;

https://reviewboard.mozilla.org/r/208938/#review215184

Comment 12

[Justin Wood (:Callek)]

:gps, is this bug still worth leaving open?

Comment 13

[Gregory Szorc [:gps]]

Yes. I (or someone) needs to land the patch(es).