Closed
Bug 1426602
Opened 7 years ago
Closed 7 years ago
Remove certcgi command
Categories
(NSS :: Test, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
3.36
People
(Reporter: franziskus, Assigned: jkt)
References
Details
Attachments
(1 file)
148.52 KB,
patch
|
franziskus
:
review+
KaiE
:
superreview+
|
Details | Diff | Splinter Review |
The certcgi "command" is a test that doesn't seem to be used. It should probably be removed.
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8938380 -
Flags: review?(franziskuskiefer)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jkt
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8938380 [details] [diff] [review]
bug-1426602.patch
Review of attachment 8938380 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
But I'll wait with landing for the new release (a week or so).
Kai, do you know of any users of this? The keygen tag (needed in certcgi) is only available in Firefox and will probably be removed in 61. So I think we should drop this command unless there's a significant user base.
Attachment #8938380 -
Flags: superreview?(kaie)
Attachment #8938380 -
Flags: review?(franziskuskiefer)
Attachment #8938380 -
Flags: review+
Reporter | ||
Updated•7 years ago
|
Target Milestone: --- → 3.36
Comment 5•7 years ago
|
||
Comment on attachment 8938380 [details] [diff] [review]
bug-1426602.patch
We aren't aware of users of certcgi. Removal should be OK.
Attachment #8938380 -
Flags: superreview?(kaie) → superreview+
Reporter | ||
Comment 6•7 years ago
|
||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•