Closed Bug 1426676 Opened 7 years ago Closed 6 years ago

Add JSON file format support as used in WebExtensions

Categories

(Webtools Graveyard :: Pontoon, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mathjazz, Assigned: mathjazz)

Details

Attachments

(2 files)

In order to support WebExtensions localization, Pontoon needs to be able to work with their JSON file format:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Internationalization

See also:
https://www.chromium.org/developers/design-documents/extensions/how-the-extension-system-works/i18n
Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/f39b33eb376a7299c4bbdec7de98138d8e977e46
Fix bug 1426676: Support for WebExtensions' JSON format (#786)

WebExtensions' JSON format support includes:
* JSON validation using jsonschema
* Marking JSON placeholders as placeables
* Displaying and linkifying placeholder examples as string metadata
* Factoring out create_parent_directory()
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Found a few issues while testing with DNS over HTTPS Studies:
https://github.com/mathjazz/http-dns/

1. Description attribute should be optional:
https://www.chromium.org/developers/design-documents/extensions/how-the-extension-system-works/i18n

2. Untranslated strings are imported with source string values.

3. Placeholder Examples metadata is displayed even if placehoder doesn't have an example.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/47469eb94457a69b31f28d333d85c58302620b00
Fix bug 1426676: Fix JSON file format bugs (#979)

Includes:
* Make description attribut optional
* Add en_US and en_us to the list of supported source directory names
* Do not render Placeholder Examples metadata if placehoder doesn't
  have an example specified
* Import untranslated strings as untranslated instead of as original strings
* Use less indent, 2 seems to be more common in Mozillaverse
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: