1426682 - remove tcanvasmark from talos

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

many years ago, :snorp had requested that we run tcanvasmark on talos.  This has been running for years, and catching a regression here and there.  In chatting with snorp last week it seemed clear that there is little real value we get from tcanvasmark today.  :snorp did suggest that we might want to replace it with something, although there was nothing he could recommend in the brief conversation we had.

I vote for disabling the test and when we have a replacement we add it when ready.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:snorp, can you give the OK to disable this test, and/or offer guidance on what you think would be any next steps?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

I think it's fine to disable -- we no longer really care about canvas 2d performance, AFAIK. Maybe it would be good to get signoff from Milan too?

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

I wouldn't say we don't care about canvas 2d performance, but it sounds like this isn't really useful at this point, so I'm happy to turn it off.

Comment 4

[Robert Wood [:rwood]]

Attachment: Bug 1426682 - Remove tcanvasmark from talos;

Review commit: https://reviewboard.mozilla.org/r/214136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214136/

Comment 5

[Robert Wood [:rwood]]

I also removed it from: https://wiki.mozilla.org/Buildbot/Talos/Tests

Comment 6

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e77a8d80aaa1f720f03dd60c726a2bad99d7564

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8943744 [details]
Bug 1426682 - Remove tcanvasmark from talos;

https://reviewboard.mozilla.org/r/214136/#review219848

looks like you found all the places!

Comment 8

[Robert Wood [:rwood]]

Comment on attachment 8943744 [details]
Bug 1426682 - Remove tcanvasmark from talos;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214136/diff/1-2/

Comment 9

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ae30c9f3eb77a58f339d1278b6108687980621e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff0fdb03af33
Remove tcanvasmark from talos; r=jmaher

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ff0fdb03af33