1426833 - Firefox logo in Pocket is the pre-photon version

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Screenshot showing the issue

STR:
1) Open Firefox with a profile with Sync/a Firefox Account
2) Click the Pocket page action in the URL bar
3) Popup is displayed with the old Fx logo in a "Sign in with Firefox" button

(Sync/FxAccount is required because otherwise the button is "Try It Now" without the logo)

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1426833 - Update Fx logos in Pocket extension to Photon versions.

Review commit: https://reviewboard.mozilla.org/r/212506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212506/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8942228 [details]
Bug 1426833 - Update Fx logos in Pocket extension to Photon versions.

https://reviewboard.mozilla.org/r/212506/#review218328

The previous icon is white, and this one is off-grey, which looks odd because the text is still white.

Do we not have a white version of the icon, or perhaps we can use the SVG version?

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Comment on attachment 8942228 [details]
Bug 1426833 - Update Fx logos in Pocket extension to Photon versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212506/diff/1-2/

Comment 4

[:Gijs (he/him)]

Comment on attachment 8942228 [details]
Bug 1426833 - Update Fx logos in Pocket extension to Photon versions.

https://reviewboard.mozilla.org/r/212506/#review219246

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb618bea01d7
Update Fx logos in Pocket extension to Photon versions. r=Gijs

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/fb618bea01d7