1427002 - Failed to load article from page on a specific page on Sparknotes (with very little text)

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[Andy Lu]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171206182557

Steps to reproduce:

Simply enter reader view while on this page:
http://www.sparknotes.com/biology/cellstructure/cellmembranes/section2/page/2/


Actual results:

You get an error saying "Failed to load article from page."


Expected results:

Page should have been displayed in Reader View. This is the only time I've received this error on Sparknotes out of all the pages I've viewed in Reader View.

Comment 1

[:Gijs (he/him)]

I'm starting to think we should just remove the lower limit for article size, see also this github issue: https://github.com/mozilla/readability/issues/381 .

`isProbablyReaderable` does its own gatekeeping here.

That said, the unfortunate thing is that the limit does currently allow for more text to be included to avoid cases where we strip "too much" stuff, by doing iterative passes. What we need to avoid is the case where, even if we found some (limited) amount of text in a previous iteration, to give up entirely and not display anything.

Comment 2

[:Gijs (he/him)]

This was probably fixed by github fix https://github.com/mozilla/readability/pull/423, and seems fixed to me in 61 (but we landed that fix in 60, so should be fixed in release already too, just can't check right now).