Closed
Bug 1427025
Opened 8 years ago
Closed 8 years ago
Remove nsCRT::memmem
Categories
(Core :: XPCOM, enhancement, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: emk, Assigned: vpit3833)
Details
(Keywords: good-first-bug)
Attachments
(2 files, 1 obsolete file)
|
1.93 KB,
patch
|
Details | Diff | Splinter Review | |
|
584 bytes,
patch
|
Details | Diff | Splinter Review |
This is not used anymore (in both m-c and c-c).
|
||
Updated•8 years ago
|
Keywords: good-first-bug
|
Assignee | |
Comment 1•8 years ago
|
||
I like to work on this bug. Based on the understanding of the title and initial comment, I am attaching this patch. Please comment.
Flags: needinfo?(nfroyd)
Attachment #8966070 -
Flags: review?(nfroyd)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8966070 [details] [diff] [review]
bug-1427025-attempt-01.patch
This patch looks good, thank you! There's no need to request review on a patch and also request needinfo from the same person, though; just requesting review on the patch is enough.
Flags: needinfo?(nfroyd)
Attachment #8966070 -
Flags: review?(nfroyd) → review+
|
|
||
Updated•8 years ago
|
Assignee: nobody → venkateshpitta
Keywords: checkin-needed
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
|
||
Comment 3•8 years ago
|
||
Thanks for the patch, Venkatesh! Before we land it, can you please attach an updated patch which includes proper commit information (name, email, and commit message)? After that, feel free to set checkin-needed on the bug again. Thanks!
Flags: needinfo?(venkateshpitta)
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8966070 -
Attachment is obsolete: true
Flags: needinfo?(venkateshpitta)
Attachment #8966331 -
Flags: checkin?(ryanvm)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8966331 [details] [diff] [review]
bug-1427025-attempt-02.patch
I'm not the person who reviewed it, but we can fix that on checkin :)
Attachment #8966331 -
Flags: checkin?(ryanvm)
|
|
||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9bbfe8e4ba8
Remove nsCRT::memmem. r=froydnj
Keywords: checkin-needed
|
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Comment 8•8 years ago
|
||
HAVE_MEMMEM (https://searchfox.org/mozilla-central/rev/6bfadf95b4a6aaa8bb3b2a166d6c3545983e179a/old-configure.in#1260) is unnecessary too.
|
|
Assignee | |
Comment 9•8 years ago
|
||
Can this patch be submitted as part of the same bug?
Attachment #8966889 -
Flags: checkin?(nfroyd)
|
|
||
Comment 10•8 years ago
|
||
Comment on attachment 8966889 [details] [diff] [review]
bug-1427025-part-02.patch
Please file a different bug for this change.
This patch is also incorrect: the check for dladdr is being removed as well, and HAVE_DLADDR is used in several places:
https://searchfox.org/mozilla-central/search?q=HAVE_DLADDR&path=
Removing the " memmem" string from that line would be the correct thing to do.
Attachment #8966889 -
Flags: checkin?(nfroyd)
You need to log in
before you can comment on or make changes to this bug.
Description
•