1427141 - CSS page-break-before can cause elements to disappear in HTML tables

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P3)

Description

[joshua.bremer]

Attachment: page-break-before-causing-content-to-not-be-displayed.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36

Steps to reproduce:

Printed the attached HTML file. (Note: I have tried this with different page break implementations; page-break-before and page-break-after)


Actual results:

 the first page has all the content displayed, the second page is missing the second and third elements that contain text.


Expected results:

Both pages when printed should look identical, or at least have the same text content.

Comment 1

[Kohei Yoshino]

It's documented at https://www.fxsitecompat.com/en-CA/docs/2017/page-break-before-after-in-print-stylesheet-may-lead-to-lack-or-overlap-of-elements/

Comment 2

[Jonathan Watt [:jwatt]]

Thank you for the nice reduced testcase.

Comment 3

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]

Comment 5

[Mats Palmgren (inactive)]

Attachment: Testcase #2

The text "THIS IS PAGE 2" is missing in Print Preview.

Comment 6

[Mats Palmgren (inactive)]

Attachment: For posterity: frame dump of Testcase #2

Comment 7

[Mats Palmgren (inactive)]

Attachment: Bug 1427141 - Request a break before the row-group if its first row doesn't fit. r=TYLin

FTR, the origin of the Reset() call in the else-branch I'm removing
is bug 397428. I think this is before we had a break-before status,
or at least before our table code knew how to deal with it, so it
might have been correct to change an INCOMPLETE status into COMPLETE
in those days. It seems the intent was to push the row-group:
https://bugzilla.mozilla.org/show_bug.cgi?id=397428#c14
"... and they all set aStatus to NS_FRAME_COMPLETE, which is logical
because we want to push this entire rowgroup to a new page and try
to reflow the row again..."

Nowadays though, returning a break-before status is the correct
way to do that.

Comment 8

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=49568a62834a5c6f09c3c2b83fcdce7c30aef32d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/111c247a2bca
Request a break before the row-group if its first row doesn't fit.  r=TYLin

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/111c247a2bca

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to Beta for Fx72 or can this ride Fx73 to release?

Comment 12

[Mats Palmgren (inactive)]

Meh, this has been broken for years and is a rarely used feature so there's no rush.