1427145 - Use toolchain artifacts instead of tooltool packages for osx (cross) repackages

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1427145 - Use toolchain artifacts instead of tooltool packages for osx (cross) repackages.

OSX (cross) repackages are currently using a tooltool manifest to get
libdmg and hfsplus. Change those jobs to use the toolchain artifacts
instead.

At the same time, modify the repackage mozharness script's _run_tooltool
so that it doesn't fail with MOZ_TOOLCHAINS being set but without a
tooltool_manifest_src, matching the similar function in buildbase.py.

Review commit: https://reviewboard.mozilla.org/r/209372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209372/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8938909 [details]
Bug 1427145 - Use toolchain artifacts instead of tooltool packages for osx (cross) repackages.

https://reviewboard.mozilla.org/r/209372/#review215204

::: taskcluster/taskgraph/transforms/repackage.py:192
(Diff revision 1)
>              'worker': worker,
>              'run': run,
>          }
> +
> +        if build_platform.startswith('macosx'):
> +            task['toolchains'] = [

If `toolchains` is already defined, this could lead to badness. Feel free to discard this issue if you don't think it matters.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Comment on attachment 8938909 [details]
> Bug 1427145 - Use toolchain artifacts instead of tooltool packages for osx
> (cross) repackages.
> 
> https://reviewboard.mozilla.org/r/209372/#review215204
> 
> ::: taskcluster/taskgraph/transforms/repackage.py:192
> (Diff revision 1)
> >              'worker': worker,
> >              'run': run,
> >          }
> > +
> > +        if build_platform.startswith('macosx'):
> > +            task['toolchains'] = [
> 
> If `toolchains` is already defined, this could lead to badness. Feel free to
> discard this issue if you don't think it matters.

Well, the whole task is defined above, so if someone adds toolchains there, they're close enough that they should notice. It's also unlikely repackages for other platforms than osx will need toolchains ever.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d6c872f416a
Use toolchain artifacts instead of tooltool packages for osx (cross) repackages. r=gps

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2d6c872f416a

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Mike Hommey [back on Jan 9] [:glandium] from comment #3)
> (In reply to Gregory Szorc [:gps] from comment #2)
> > Comment on attachment 8938909 [details]
> > Bug 1427145 - Use toolchain artifacts instead of tooltool packages for osx
> > (cross) repackages.
> > 
> > https://reviewboard.mozilla.org/r/209372/#review215204
> > 
> > ::: taskcluster/taskgraph/transforms/repackage.py:192
> > (Diff revision 1)
> > >              'worker': worker,
> > >              'run': run,
> > >          }
> > > +
> > > +        if build_platform.startswith('macosx'):
> > > +            task['toolchains'] = [
> > 
> > If `toolchains` is already defined, this could lead to badness. Feel free to
> > discard this issue if you don't think it matters.
> 
> Well, the whole task is defined above, so if someone adds toolchains there,
> they're close enough that they should notice. It's also unlikely repackages
> for other platforms than osx will need toolchains ever.

Just FYI: I don't think this is true.  I would guess that "most" exotic platforms will need the platform SDK -- Android certainly does, and I expect iOS would too -- and those SDKs will be delivered via toolchains.