Closed
Bug 1427187
Opened 5 years ago
Closed 4 years ago
Update Debugger Frontend (12-27)
Categories
(DevTools :: Debugger, enhancement)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 3 obsolete files)
132.86 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jlaster
Depends on: debugger-bundle-updates
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=817ce1cafe764a7352ab34934c32556d6ef2f19d
Assignee | ||
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0de4c6603b05ca5344860414e00e5b489a714785
Assignee | ||
Comment 3•5 years ago
|
||
Attachment #8938951 -
Flags: review?(jdescottes)
Assignee | ||
Comment 4•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dc711de711d60215ec0a602a455119b676a9874
Assignee | ||
Comment 5•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0703456a7cb2f5ff9c39af4e4b7b7e23570427a8
Assignee | ||
Updated•5 years ago
|
Attachment #8938951 -
Attachment is obsolete: true
Attachment #8938951 -
Flags: review?(jdescottes)
Assignee | ||
Comment 6•5 years ago
|
||
Attachment #8938964 -
Flags: review?(jdescottes)
Comment 7•5 years ago
|
||
Comment on attachment 8938964 [details] [diff] [review] patch-12-27-2.patch Review of attachment 8938964 [details] [diff] [review]: ----------------------------------------------------------------- Invalid (local?) commit in README. I also see a leak on try, but not sure the runs posted in bugzilla match the current patch. ::: devtools/client/debugger/new/README.mozilla @@ +1,4 @@ > This is the debugger.html project output. > See https://github.com/devtools-html/debugger.html > > +Taken from upstream commit: d96af0192084a3bdb66b916c7336aa80fcf3c69a Can't find this commit on debugger.html
Attachment #8938964 -
Flags: review?(jdescottes) → review-
Assignee | ||
Comment 8•4 years ago
|
||
updates the sha
Attachment #8938964 -
Attachment is obsolete: true
Attachment #8939615 -
Flags: review?(jdescottes)
Assignee | ||
Comment 9•4 years ago
|
||
Links: + Commit - https://github.com/devtools-html/debugger.html/commit/0f6983e5343bb7a63ee120c99dcbdb0ccdec2e17 + Branch - https://github.com/devtools-html/debugger.html/tree/release-3 + Comparison - https://github.com/devtools-html/debugger.html/compare/release-3...release-4?expand=1
Assignee | ||
Comment 10•4 years ago
|
||
Attachment #8939615 -
Attachment is obsolete: true
Attachment #8939615 -
Flags: review?(jdescottes)
Attachment #8939894 -
Flags: review?(jdescottes)
Assignee | ||
Comment 11•4 years ago
|
||
Try Run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01781f81e24a11f997718701701427e8ba33cbaa Comparison: https://github.com/devtools-html/debugger.html/compare/release-3...release-4 Branch: + Branch - https://github.com/devtools-html/debugger.html/tree/release-4 Commit: https://github.com/devtools-html/debugger.html/commit/0bcf3e687305960077e1255510e424d0437a3b69
Comment 12•4 years ago
|
||
Comment on attachment 8939894 [details] [diff] [review] 12-27-4.patch Review of attachment 8939894 [details] [diff] [review]: ----------------------------------------------------------------- LGTM https://github.com/devtools-html/debugger.html/compare/f98e56ff661460044382df55bd33cea601e093f0...0bcf3e687305960077e1255510e424d0437a3b69
Attachment #8939894 -
Flags: review?(jdescottes) → review+
Updated•4 years ago
|
Blocks: debugger-bundle-updates
No longer depends on: debugger-bundle-updates
Comment 13•4 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c2e9837df732 Update Debugger frontend (12-27). r=jdescottes
![]() |
||
Comment 14•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c2e9837df732
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•