Closed Bug 1427187 Opened 3 years ago Closed 3 years ago

Update Debugger Frontend (12-27)

Categories

(DevTools :: Debugger, enhancement)

Product:
DevTools
Component:
Debugger
Version:
57 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 3 obsolete files)

12-27-4.patch
132.86 KB, patch
jdescottes
: review+
Details | Diff | Splinter Review 
No description provided.
Assignee: nobody → jlaster
Depends on: debugger-bundle-updates
Attached patch patch-12-27-1.patch (obsolete) — — Splinter Review
Attachment #8938951 - Flags: review?(jdescottes)
Attachment #8938951 - Attachment is obsolete: true
Attachment #8938951 - Flags: review?(jdescottes)
Attached patch patch-12-27-2.patch (obsolete) — — Splinter Review
Attachment #8938964 - Flags: review?(jdescottes)
Comment on attachment 8938964 [details] [diff] [review]
patch-12-27-2.patch

Review of attachment 8938964 [details] [diff] [review]:
-----------------------------------------------------------------

Invalid (local?) commit in README. I also see a leak on try, but not sure the runs posted in bugzilla match the current patch.

::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> +Taken from upstream commit: d96af0192084a3bdb66b916c7336aa80fcf3c69a

Can't find this commit on debugger.html
Attachment #8938964 - Flags: review?(jdescottes) → review-
Attached patch patch-12-27-3.patch (obsolete) — — Splinter Review 
updates the sha
Attachment #8938964 - Attachment is obsolete: true
Attachment #8939615 - Flags: review?(jdescottes)
Attached patch 12-27-4.patch — — Splinter Review
Attachment #8939615 - Attachment is obsolete: true
Attachment #8939615 - Flags: review?(jdescottes)
Attachment #8939894 - Flags: review?(jdescottes)
See Also: → 1428105
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2e9837df732
Update Debugger frontend (12-27). r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/c2e9837df732
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.