1427398 - building language packs shouldn't require all l10n changesets to be already public

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Creating a language pack http://developer.mozilla.org/en/docs/Creating_a_Language_Pack fails if the latest changeset is not yet public (e.g. local locale testing before pushing it). E.g. |mozmake langpack-de LOCALE_MERGEDIR=$(PWD)/mergedir| fails with:

c:/Mozilla/Coding/Code/objdir-firefox-beta/_virtualenv/Scripts/python.exe -m mozbuild.action.langpack_manifest --locales de --min-app-ver 58.0 --max-app-ver 58.* --app-name "Nightly" --l10n-basedir "c:/Mozilla/Coding/Code/l10n-beta" --defines c:/Mozilla/Coding/Code/l10n-beta/de/toolkit/defines.inc c:/Mozilla/Coding/Code/l10n-beta/de/browser/defines.inc  --input ../../dist/xpi-stage/locale-de
Traceback (most recent call last):
  File "c:\Mozilla\Coding\Buildtools\MozillaBuild\python\Lib\runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "c:\Mozilla\Coding\Buildtools\MozillaBuild\python\Lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "c:\Mozilla\Coding\Code\mozilla-beta\python\mozbuild\mozbuild\action\langpack_manifest.py", line 448, in <module>
    main(sys.argv[1:])
  File "c:\Mozilla\Coding\Code\mozilla-beta\python\mozbuild\mozbuild\action\langpack_manifest.py", line 442, in main
    chrome_entries
  File "c:\Mozilla\Coding\Code\mozilla-beta\python\mozbuild\mozbuild\action\langpack_manifest.py", line 403, in create_webmanifest
    'version': get_timestamp_for_locale(os.path.join(l10n_basedir, loc)),
  File "c:\Mozilla\Coding\Code\mozilla-beta\python\mozbuild\mozbuild\action\langpack_manifest.py", line 96, in get_timestamp_for_locale
    dt = get_dt_from_hg(path)
  File "c:\Mozilla\Coding\Code\mozilla-beta\python\mozbuild\mozbuild\action\langpack_manifest.py", line 70, in get_dt_from_hg
    date = data['pushdate'][0]
TypeError: string indices must be integers
mozmake: *** [c:/Mozilla/Coding/Code/mozilla-beta/toolkit/locales/l10n.mk:219: langpack-de] Error 1

This fails because langpack_manifest.py tries to fetch the push timestamp from the server but the changeset is unknown if it only exists locally.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1427398 - building language packs shouldn't require all l10n changesets to be already public.

Review commit: https://reviewboard.mozilla.org/r/209542/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209542/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks for picking this up :aryx! I like the patch!

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8939123 [details]
Bug 1427398 - building language packs shouldn't require all l10n changesets to be already public.

https://reviewboard.mozilla.org/r/209542/#review216816

TIL about another consumer of pushlog data!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39ccd499bea6
building language packs shouldn't require all l10n changesets to be already public. r=gps

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/39ccd499bea6