Closed
Bug 1427744
Opened 5 years ago
Closed 4 years ago
Extend tab closing and switching Telemetry probes
Categories
(Firefox :: Tabbed Browser, enhancement)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file)
The following probes are set to expire on 2018-01-22, and are still important in our measurement of tab closing and switching performance: FX_TAB_CLOSE_PERMIT_UNLOAD_TIME_M FX_TAB_CLOSE_TIME_ANIM_MS FX_TAB_CLOSE_TIME_NO_ANIM_MS FX_TAB_SWITCH_TOTAL_E10S_MS TABCHILD_PAINT_TIME I'd like to kick the can and extend them another set of versions.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•5 years ago
|
||
Hey liuche, are you willing to sign-off on this with a data-review+?
Flags: needinfo?(liuche)
Comment 3•5 years ago
|
||
mozreview-review |
Comment on attachment 8939569 [details] Bug 1427744 - Extend the lifetime of Telemetry probes that measure tab close and switch performance. , data-review=liuche https://reviewboard.mozilla.org/r/209882/#review215448 rs=me, but do we ever want these to expire? Maybe we should just set them to expires=never? (AIUI you will still need data/privacy-review to extend the probes here)
Attachment #8939569 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to :Gijs from comment #3) > rs=me, but do we ever want these to expire? Maybe we should just set them to > expires=never? > I could be wrong on this, but I seem to recall that "expires never" is discouraged because we might then forget about the probes and collect forever without thinking about whether we need the data anymore. This kinda "renewal" model means we have to consider it every once in a while. I'm not 100% sure on the policy, however. > (AIUI you will still need data/privacy-review to extend the probes here) Yep! liuche needinfo'd. :)
Updated•5 years ago
|
Assignee: nobody → mconley
Comment 5•4 years ago
|
||
Comment on attachment 8939569 [details] Bug 1427744 - Extend the lifetime of Telemetry probes that measure tab close and switch performance. , data-review=liuche Try confirms that this fixes the issues reported in bug 1428081.
Attachment #8939569 -
Flags: review?(liuche)
Attachment #8939569 -
Flags: feedback+
Comment 6•4 years ago
|
||
Comment on attachment 8939569 [details] Bug 1427744 - Extend the lifetime of Telemetry probes that measure tab close and switch performance. , data-review=liuche Yes! Approving this extension of the probe.
Flags: needinfo?(liuche)
Attachment #8939569 -
Flags: review?(liuche) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5b318239826f Extend the lifetime of Telemetry probes that measure tab close and switch performance. r=Gijs, data-review=liuche
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5b318239826f
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•