1427744 - Extend tab closing and switching Telemetry probes

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

The following probes are set to expire on 2018-01-22, and are still important in our measurement of tab closing and switching performance:

FX_TAB_CLOSE_PERMIT_UNLOAD_TIME_M
FX_TAB_CLOSE_TIME_ANIM_MS
FX_TAB_CLOSE_TIME_NO_ANIM_MS
FX_TAB_SWITCH_TOTAL_E10S_MS
TABCHILD_PAINT_TIME

I'd like to kick the can and extend them another set of versions.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1427744 - Extend the lifetime of Telemetry probes that measure tab close and switch performance. , data-review=liuche

Review commit: https://reviewboard.mozilla.org/r/209882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209882/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey liuche, are you willing to sign-off on this with a data-review+?

Comment 3

[:Gijs (he/him)]

Comment on attachment 8939569 [details]
Bug 1427744 - Extend the lifetime of Telemetry probes that measure tab close and switch performance. , data-review=liuche

https://reviewboard.mozilla.org/r/209882/#review215448

rs=me, but do we ever want these to expire? Maybe we should just set them to expires=never?

(AIUI you will still need data/privacy-review to extend the probes here)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

(In reply to :Gijs from comment #3)
> rs=me, but do we ever want these to expire? Maybe we should just set them to
> expires=never?
> 

I could be wrong on this, but I seem to recall that "expires never" is discouraged because we might then forget about the probes and collect forever without thinking about whether we need the data anymore. This kinda "renewal" model means we have to consider it every once in a while. I'm not 100% sure on the policy, however.

> (AIUI you will still need data/privacy-review to extend the probes here)

Yep! liuche needinfo'd. :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8939569 [details]
Bug 1427744 - Extend the lifetime of Telemetry probes that measure tab close and switch performance. , data-review=liuche

Try confirms that this fixes the issues reported in bug 1428081.

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8939569 [details]
Bug 1427744 - Extend the lifetime of Telemetry probes that measure tab close and switch performance. , data-review=liuche

Yes! Approving this extension of the probe.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b318239826f
Extend the lifetime of Telemetry probes that measure tab close and switch performance. r=Gijs, data-review=liuche

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/5b318239826f