Closed
Bug 1427745
Opened 6 years ago
Closed 6 years ago
Enable ESLint rule mozilla/use-services for dom/media
Categories
(Core :: WebRTC: Signaling, enhancement, P3)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
As we've been doing elsewhere, this continues the work to replace .getService() with Services.jsm uses where possible and enable the mozilla/use-services rule, this has small gains in performance (less boundary crossing) and generally more easy to read code.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8939545 [details] Bug 1427745 - Enable ESLint rule mozilla/use-services for dom/media. https://reviewboard.mozilla.org/r/209866/#review215526
Attachment #8939545 -
Flags: review?(jib) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7000040f2b07 Enable ESLint rule mozilla/use-services for dom/media. r=jib
Pushed by apavel@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/76ebca930f8c Enable ESLint rule mozilla/use-services for dom/media. r=jib
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/76ebca930f8c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7000040f2b07
You need to log in
before you can comment on or make changes to this bug.
Description
•