Closed
Bug 1427754
Opened 6 years ago
Closed 6 years ago
Enable ESLint rule mozilla/use-services for accessible/
Categories
(Core :: Disability Access APIs, enhancement)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
As we've been doing elsewhere, this continues the work to replace .getService() with Services.jsm uses where possible and enable the mozilla/use-services rule, this has small gains in performance (less boundary crossing) and generally more easy to read code. For accessible/'s case this just affects test files.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•6 years ago
|
Attachment #8939550 -
Flags: review?(surkov.alexander)
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8939550 [details] Bug 1427754 - Enable ESLint rule mozilla/use-services for accessible/ https://reviewboard.mozilla.org/r/209870/#review215516
Attachment #8939550 -
Flags: review?(surkov.alexander) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e31bd656aded Enable ESLint rule mozilla/use-services for accessible/ r=surkov
Pushed by apavel@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/d7e963d8e08a Enable ESLint rule mozilla/use-services for accessible/ r=surkov
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d7e963d8e08a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e31bd656aded
You need to log in
before you can comment on or make changes to this bug.
Description
•