1427818 - Fix browser_layoutHelpers-getBoxQuads.js on e10s

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

browser_layoutHelpers-getBoxQuads.js currently fails with:
TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_layoutHelpers-getBoxQuads.js | Uncaught exception - at resource://devtools/shared/base-loader.js -> resource://devtools/shared/layout/utils.js:198 - Error: unsafe CPOW usage forbidden
Stack trace:
    getAdjustedQuads@resource://devtools/shared/base-loader.js -> resource://devtools/shared/layout/utils.js:198:16
    returnsTheRightDataStructure@chrome://mochitests/content/browser/devtools/client/shared/test/browser_layoutHelpers-getBoxQuads.js:38:15

Comment 1

[Alexandre Poirot [:ochameau]]

Somewhat green try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1f61818ec4abb6a1292579f7d17bbc40c7c4a97&selectedJob=153898213
(I fixed the eslint failures in the latest patch)

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1427818 - Fix browser_layoutHelpers-getBoxQuads.js on e10s.

Review commit: https://reviewboard.mozilla.org/r/210060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210060/

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8939755 [details]
Bug 1427818 - Fix browser_layoutHelpers-getBoxQuads.js on e10s.

https://reviewboard.mozilla.org/r/210060/#review215750

I agree with the approach (which is the same you've used in other tests I already reviewed).
I would just like to move and comment some code so that the communication mechanism used in this test is easy to understand.

::: devtools/client/shared/test/browser_layoutHelpers-getBoxQuads.js:16
(Diff revision 1)
> -
> -  ok(typeof getAdjustedQuads === "function", "getAdjustedQuads is defined");
>  
>    info("Running tests");
>  
> -  returnsTheRightDataStructure(doc);
> +  let mm = tab.linkedBrowser.messageManager;

Please add a comment line before this block of code explaining why this command thing is even needed.
If I understand correctly, window.FullZoom isn't available from the ContentTask, right? Which is why you need to run it in this process instead, and therefore expose it via the MM.
If that's correct, then the comment should say this.

::: devtools/client/shared/test/browser_layoutHelpers-getBoxQuads.js:211
(Diff revision 1)
> -  ok(zoomedInQuad.bounds.width > defaultQuad.bounds.width,
> +      ok(zoomedInQuad.bounds.width > defaultQuad.bounds.width,
> -    "The zoomed in quad is bigger than the default one");
> +        "The zoomed in quad is bigger than the default one");
> -  ok(zoomedInQuad.bounds.height > defaultQuad.bounds.height,
> +      ok(zoomedInQuad.bounds.height > defaultQuad.bounds.height,
> -    "The zoomed in quad is bigger than the default one");
> +        "The zoomed in quad is bigger than the default one");
>  
> +      function sendCommand(cmd) {

This function seems a bit misplaced. It is used before and after this location. 
Can you please move it all the way up, as the first part of the ContentTask script?
This way it will be close to the MM listener just before.

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8939755 [details]
Bug 1427818 - Fix browser_layoutHelpers-getBoxQuads.js on e10s.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210060/diff/1-2/

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8939755 [details]
Bug 1427818 - Fix browser_layoutHelpers-getBoxQuads.js on e10s.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210060/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a66b031b9f6b
Fix browser_layoutHelpers-getBoxQuads.js on e10s. r=pbro

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/a66b031b9f6b