Open Bug 1427913 Opened 2 years ago Updated 2 years ago

Search Box inconsistent behavior: pressing enter searches in new tab but clicking "go" arrow searches in current tab.

Categories

(Firefox :: Search, defect, P5)

58 Branch
defect

Tracking

()

People

(Reporter: jsheffer, Unassigned)

Details

(Whiteboard: [fxsearch])

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171226085105

Steps to reproduce:

Browser.search.openintab value is set to True (set to open new searches in a new tab).  Enter a search term in the search box.  If you press enter on the keyboard, the search results will open in a new tab (i.e. obeying the preferred setting).  If you instead just click the search arrow to the right of the search box, the search results will open in the current tab, overwriting whatever was there (i.e. not obeying the preferred settings).


Actual results:

If you press enter on the keyboard, the search results will open in a new tab (i.e. obeying the preferred setting).  If you instead just click the search arrow to the right of the search box, the search results will open in the current tab, overwriting whatever was there (i.e. not obeying the preferred settings).


Expected results:

If browser.search.openintab is set to true, search results should open in a new tab irrespective of the entry method.
Component: Untriaged → Search
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5
Whiteboard: [fxsearch]
Looks like we don't check the pref specifically when you click the go button.  I don't know why.  https://dxr.mozilla.org/mozilla-central/rev/351c75ab74c9a83db5c0662ba271b49479adb1f1/browser/components/search/content/search.xml#359
You need to log in before you can comment on or make changes to this bug.