1427913 - Search Box inconsistent behavior: pressing enter searches in new tab but clicking "go" arrow searches in current tab.

Status: RESOLVED DUPLICATE of bug 513180

(Firefox :: Search, defect, P5)

Description

[Joe Sheffer]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171226085105

Steps to reproduce:

Browser.search.openintab value is set to True (set to open new searches in a new tab).  Enter a search term in the search box.  If you press enter on the keyboard, the search results will open in a new tab (i.e. obeying the preferred setting).  If you instead just click the search arrow to the right of the search box, the search results will open in the current tab, overwriting whatever was there (i.e. not obeying the preferred settings).


Actual results:

If you press enter on the keyboard, the search results will open in a new tab (i.e. obeying the preferred setting).  If you instead just click the search arrow to the right of the search box, the search results will open in the current tab, overwriting whatever was there (i.e. not obeying the preferred settings).


Expected results:

If browser.search.openintab is set to true, search results should open in a new tab irrespective of the entry method.

Comment 1

[Drew Willcoxon :adw]

Looks like we don't check the pref specifically when you click the go button.  I don't know why.  https://dxr.mozilla.org/mozilla-central/rev/351c75ab74c9a83db5c0662ba271b49479adb1f1/browser/components/search/content/search.xml#359

Comment 2

[Tanner Drake]

This might be a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=513180

Comment 3

[Mark Banner (:standard8)]

(In reply to Tanner Drake from comment #2)

This might be a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=513180

Yes, it looks close enough to me. Thank you for commenting.