Closed
Bug 1427947
Opened 6 years ago
Closed 6 years ago
Dispatch `shippingoptionchange` when the shipping option is changed
Categories
(Firefox :: WebPayments UI, defect, P1)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: MattN, Assigned: jaws)
References
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
Use `paymentSrv.changeShippingOption(requestId, optionID);`[1] [1] https://dxr.mozilla.org/mozilla-central/rev/351c75ab74c9a83db5c0662ba271b49479adb1f1/dom/interfaces/payments/nsIPaymentRequestService.idl#56
Reporter | ||
Updated•6 years ago
|
Priority: P3 → P1
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8951395 [details] Bug 1427947 - Dispatch `shippingoptionchange` when the shipping option is changed. https://reviewboard.mozilla.org/r/220672/#review226632 Thanks ::: toolkit/components/payments/test/browser/browser_show_dialog.js:155 (Diff revision 1) > + info("changing shipping option to 'drone' from default selected option of 'standard'"); > + spawnPaymentDialogTask(frame, PTU.DialogContentTasks.selectShippingOptionById, "drone"); > + > + info("clicking pay"); > + spawnPaymentDialogTask(frame, PTU.DialogContentTasks.completePayment); Can you add a content task before this that actually listens for the event in the merchant page and resolves the content task promise when the event is received. Otherwise we're not actually testing that the event happens. (I guess the same really applies to the shipping address change event)
Attachment #8951395 -
Flags: review?(MattN+bmo) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b1aa6958142 Dispatch `shippingoptionchange` when the shipping option is changed. r=MattN
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b1aa6958142
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•6 years ago
|
Whiteboard: [webpayments]
Updated•6 years ago
|
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•