Closed Bug 1427947 Opened 3 years ago Closed 3 years ago

Dispatch `shippingoptionchange` when the shipping option is changed

Categories

(Firefox :: WebPayments UI, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: MattN, Assigned: jaws)

References

Details

(Whiteboard: [webpayments])

Attachments

(1 file)

Priority: P3 → P1
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8951395 [details]
Bug 1427947 - Dispatch `shippingoptionchange` when the shipping option is changed.

https://reviewboard.mozilla.org/r/220672/#review226632

Thanks

::: toolkit/components/payments/test/browser/browser_show_dialog.js:155
(Diff revision 1)
> +    info("changing shipping option to 'drone' from default selected option of 'standard'");
> +    spawnPaymentDialogTask(frame, PTU.DialogContentTasks.selectShippingOptionById, "drone");
> +
> +    info("clicking pay");
> +    spawnPaymentDialogTask(frame, PTU.DialogContentTasks.completePayment);

Can you add a content task before this that actually listens for the event in the merchant page and resolves the content task promise when the event is received. Otherwise we're not actually testing that the event happens. (I guess the same really applies to the shipping address change event)
Attachment #8951395 - Flags: review?(MattN+bmo) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b1aa6958142
Dispatch `shippingoptionchange` when the shipping option is changed. r=MattN
https://hg.mozilla.org/mozilla-central/rev/3b1aa6958142
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1440843
Whiteboard: [webpayments]
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
You need to log in before you can comment on or make changes to this bug.