Closed Bug 1428002 Opened 2 years ago Closed 2 years ago

Enable <script type="module"> in nightly builds

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

(Keywords: dev-doc-needed)

Attachments

(2 files)

When the web platform tests failures related to module scripts are fixed, I'd like to enable this feature by default in nightly builds.  It's preffed off.
It's currently preffed off, that should read.
Priority: -- → P3
Patch to enable modules in nightly.  What do you think?  Do I need to send a dev.platform email for this?
Attachment #8940798 - Flags: review?(bugs)
Yes, please send email to dev.platform.

I guess we don't need to support module workers yet.
Chrome bug for that is https://bugs.chromium.org/p/chromium/issues/detail?id=680046
Comment on attachment 8940798 [details] [diff] [review]
bug1428002-enable-in-nightly

oh, this is nightly only... well, even then it would be good to notify dev.platform, but this isn't really intent-to-ship yet.
Attachment #8940798 - Flags: review?(bugs) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f972e51e33
Enable <script type="module"> in nightly builds r=smaug
Patch to update test code that expects module scripts to not be enabled.

To deal with modules being enabled on nightly but disabled elsewhere, the WPT tests set the pref explicitly.
Flags: needinfo?(jcoppeard)
Attachment #8941082 - Flags: review?(bugs)
Comment on attachment 8941082 [details] [diff] [review]
bug1428002-fix-tests

removing test_moduleScriptsNotRun.html is a bit annoying, but I guess it is ok atm.
Attachment #8941082 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #8)
> removing test_moduleScriptsNotRun.html is a bit annoying, but I guess it is
> ok atm.

I think I can make it just skip this test on nightly.  I'll do that.
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e14dd890c5e
Enable <script type="module"> in nightly builds r=smaug
https://hg.mozilla.org/mozilla-central/rev/8e14dd890c5e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.