1428002 - Enable <script type="module"> in nightly builds

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Jon Coppeard (:jonco)]

When the web platform tests failures related to module scripts are fixed, I'd like to enable this feature by default in nightly builds.  It's preffed off.

Comment 1

[Jon Coppeard (:jonco)]

It's currently preffed off, that should read.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bug1428002-enable-in-nightly

Patch to enable modules in nightly.  What do you think?  Do I need to send a dev.platform email for this?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Yes, please send email to dev.platform.

I guess we don't need to support module workers yet.
Chrome bug for that is https://bugs.chromium.org/p/chromium/issues/detail?id=680046

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8940798 [details] [diff] [review]
bug1428002-enable-in-nightly

oh, this is nightly only... well, even then it would be good to notify dev.platform, but this isn't really intent-to-ship yet.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f972e51e33
Enable <script type="module"> in nightly builds r=smaug

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 28f972e51e33 (bug 1428002) for wpt1 failures in /html/dom/interfaces.html

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7ddce698d4b2eb799287f03731a2302c1cd7712c&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=0894fbaddc88e7f6b9cd6bb5f9cad6cf81254ecc&selectedJob=155005877
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ddce698d4b2eb799287f03731a2302c1cd7712c

Comment 7

[Jon Coppeard (:jonco)]

Attachment: bug1428002-fix-tests

Patch to update test code that expects module scripts to not be enabled.

To deal with modules being enabled on nightly but disabled elsewhere, the WPT tests set the pref explicitly.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8941082 [details] [diff] [review]
bug1428002-fix-tests

removing test_moduleScriptsNotRun.html is a bit annoying, but I guess it is ok atm.

Comment 9

[Jon Coppeard (:jonco)]

(In reply to Olli Pettay [:smaug] from comment #8)
> removing test_moduleScriptsNotRun.html is a bit annoying, but I guess it is
> ok atm.

I think I can make it just skip this test on nightly.  I'll do that.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e14dd890c5e
Enable <script type="module"> in nightly builds r=smaug

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8e14dd890c5e