1428035 - Pin, Edit and Dismiss icons are not correctly centered in their buttons on Windows

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: IMG_04012018_143501_0.png

[Notes]:
- The issue is not reproducible on Mac and Linux.
- The Pin, Edit and Dismiss icons are also lowered in the Top Sites Edit menu.
- It seems that this was always the case, but the addition of the Edit button on the placeholders made things more apparent.

[Affected versions]:
- Firefox 59.0a1 Build ID 20180103100101

[Affected Platforms]:
- All Windows

[Prerequisites]:
- Have a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites.
2. Hover an empty Top Sites placeholder.
3. Observe the "Edit this site" icon in the button.
 
[Expected results]:
- The icon is centered inside the button.

[Actual results]:
- The icon is lowered inside the button.

[Additional Notes]:
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3915

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/7ab70e413900bff2b54ea639424084b0a78e1360
fix(styles): Make placeholder edit button use same style as context menu (#3915)

Fix Bug 1428035 - Pin, Edit and Dismiss icons are not correctly centered in their buttons on Windows
Make placeholder edit button use same style as context menu so it's not too small and off-centre in windows. Design r=bryan

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/66429a3ae434

Comment 4

[Sajedul Islam]

I have reproduced this bug with Nightly 59.0a1 (2018-01-04) on Windows 7, 64 Bit ! 

This bug's fix is Verified with latest Nightly!

Build   ID    20180110100224
User Agent    Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

[bugday-20180110]

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Marking as verified based on comment 4.