PlacesUtils.isRootItem should take GUIDs as well as item IDs

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks 1 bug)

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Assignee

Description

2 years ago
As part of my work on bug 1423896 it would be useful if isRootItem can take a guid as well as an id.

Since there's a bit of test rework involved to obsolete the old test, and provide new tests to cover the work of the old test with the new apis, then I'm splitting this out to a separate bug.

It will also aid towards bug 1071511 - where we're replacing ids with guids.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8939846 [details]
Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids.

https://reviewboard.mozilla.org/r/210154/#review215876
Attachment #8939846 - Flags: review?(mak77) → review+

Comment 4

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99f4d3702ed6
Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak

Comment 5

2 years ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/ed1d0d623ca4
Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ed1d0d623ca4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.