1428049 - Error when running Talos locally

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Ionuț Goldan [:igoldan]]

Running |./mach talos-test -a tpaint| locally fails with following traceback:

15:05:49     INFO -  Invalid requirement: '../tools/mozterm'
15:05:49    ERROR -  Traceback (most recent call last):
15:05:49     INFO -    File "e:\workspace\mozilla-source\mozilla-central\objdir-frontend\testing\talos-venv\lib\site-packages\pip\req\req_install.py", line 78, in __init__
15:05:49     INFO -      req = Requirement(req)
15:05:49     INFO -    File "e:\workspace\mozilla-source\mozilla-central\objdir-frontend\testing\talos-venv\lib\site-packages\pip\_vendor\packaging\requirements.py", line 96, in __init__
15:05:49     INFO -      requirement_string[e.loc:e.loc + 8]))
15:05:49     INFO -  InvalidRequirement: Invalid requirement, parse error at "u'../tools'"
15:05:49     INFO -  You are using pip version 8.1.2, however version 9.0.1 is available.
15:05:49     INFO -  You should consider upgrading via the 'python -m pip install --upgrade pip' command.
15:05:49  WARNING - Return code: 1
15:05:49     INFO - retry: Failed, sleeping 60 seconds before retrying
15:05:52     INFO - Running post-action listener: _resource_record_post_action
15:05:52     INFO - Running post-action listener: _start_resource_monitoring

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:ahal added this yesterday, I assume he would know of any fixes here.

Comment 2

[Andrew Halberstadt [:ahal]]

I have a fix. I think this will also need another mozlog version bump (in my defense I had landed this before jgraham reminded me about version bumping yesterday).

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1428049 - [talos] Create a separate mozbase_source_requirements.txt when installing packages from the source dir,

This fixes a regression to |mach talos-test| around a missing 'mozterm'
dependency.

Review commit: https://reviewboard.mozilla.org/r/210168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210168/

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1428049 - [mozlog] Add mozterm as a mozlog dependency and version bump to 3.7,

Review commit: https://reviewboard.mozilla.org/r/210170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210170/

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8939858 [details]
Bug 1428049 - [mozlog] Add mozterm as a mozlog dependency and version bump to 3.7,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210170/diff/1-2/

Comment 6

[Ionuț Goldan [:igoldan]]

Comment on attachment 8939858 [details]
Bug 1428049 - [mozlog] Add mozterm as a mozlog dependency and version bump to 3.7,

https://reviewboard.mozilla.org/r/210170/#review215862

I tested the changes here and they resolve the bug. Thanks!

::: testing/mozbase/mozlog/setup.py:28
(Diff revision 2)
>        author_email='[e-mail]',
>        url='https://wiki.mozilla.org/Auto-tools/Projects/Mozbase',
>        license='MPL 1.1/GPL 2.0/LGPL 2.1',
>        packages=find_packages(),
>        zip_safe=False,
> -      install_requires=['blessings >= 1.3',
> +      install_requires=DEPS,

So, mozbase package will be searched for locally, then installed, right? I don't think you uploaded it to PyPI.

Comment 7

[Ionuț Goldan [:igoldan]]

Comment on attachment 8939857 [details]
Bug 1428049 - [talos] Create a separate mozbase_source_requirements.txt when installing packages from the source dir,

https://reviewboard.mozilla.org/r/210168/#review215866

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2de67592fbd
[talos] Create a separate mozbase_source_requirements.txt when installing packages from the source dir, r=igoldan
https://hg.mozilla.org/integration/autoland/rev/6310cc3692ff
[mozlog] Add mozterm as a mozlog dependency and version bump to 3.7, r=igoldan

Comment 9

[Andrew Halberstadt [:ahal]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #6)
> ::: testing/mozbase/mozlog/setup.py:28
> (Diff revision 2)
> >        author_email='[e-mail]',
> >        url='https://wiki.mozilla.org/Auto-tools/Projects/Mozbase',
> >        license='MPL 1.1/GPL 2.0/LGPL 2.1',
> >        packages=find_packages(),
> >        zip_safe=False,
> > -      install_requires=['blessings >= 1.3',
> > +      install_requires=DEPS,
> 
> So, mozbase package will be searched for locally, then installed, right? I
> don't think you uploaded it to PyPI.

Yeah, both mozterm and mozbase packages will still be installed from the local source checkout. Also correct, I haven't uploaded mozlog 3.7 to pypi yet, I'll wait for this to get merged to central first, just in case it gets backed out.

Comment 10

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/c2de67592fbd
https://hg.mozilla.org/mozilla-central/rev/6310cc3692ff