Closed Bug 1428077 Opened 2 years ago Closed 2 years ago

Many builds are going to permafail when Gecko 59 merges to Beta on 2018-01-11

Categories

(Core :: DOM: Workers, defect, blocker)

58 Branch
defect
Not set
blocker

Tracking

()

VERIFIED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: bkelly)

References

Details

Attachments

(1 file)

Fallout from bug 1426162 it appears. The patch below should suffice to reproduce it locally:
https://hg.mozilla.org/try/rev/dd4fc7e4ab3aef7319c712672f98ec7dc3a9a22d

https://treeherder.mozilla.org/logviewer.html#?job_id=154118538&repo=try

/builds/worker/workspace/build/src/dom/workers/ScriptLoader.cpp:1206:38: error: 'class mozilla::dom::workers::WorkerPrivate' has no member named 'FinalChannelPrincipalIsValid'
Flags: needinfo?(bkelly)
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Flags: needinfo?(bkelly)
Attachment #8939988 - Flags: review?(amarchesini)
Attachment #8939988 - Flags: review?(amarchesini) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3941107ff025
Make FinalChannelPrincipalIsValid always defined instead of only for MOZ_DIAGNOSTIC_ASSERT. r=baku
https://hg.mozilla.org/mozilla-central/rev/3941107ff025
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.