1428098 - Don't reconfig the video encoder stack manually

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Andreas Pehrson [:pehrsons]]

We currently have code that stops passing frame to the encoder while asynchronously tearing it down and starting a new one when input resolution changes.

The encoder stack can now handle resolution changes so this work is unnecessary.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1428098 - Do not reconfigure manually when input resolution changes.

webrtc.org now handles this.

Review commit: https://reviewboard.mozilla.org/r/211046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211046/

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8940778 [details]
Bug 1428098 - Do not reconfigure manually when input resolution changes.

https://reviewboard.mozilla.org/r/211046/#review216860

Much nicer! lgtm.

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 5996208949c0 -d b7790af77bfd: rebasing 441671:5996208949c0 "Bug 1428098 - Do not reconfigure manually when input resolution changes. r=dminor"
merging media/webrtc/signaling/gtest/videoconduit_unittests.cpp
merging media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
merging media/webrtc/signaling/src/media-conduit/VideoConduit.h
warning: conflicts while merging media/webrtc/signaling/src/media-conduit/VideoConduit.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8940778 [details]
Bug 1428098 - Do not reconfigure manually when input resolution changes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211046/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf98edea331a
Do not reconfigure manually when input resolution changes. r=dminor

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bf98edea331a