Closed Bug 1428153 Opened 7 years ago Closed 7 years ago

Perma test-verify toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref not committed - got true, expected null

Categories

(Toolkit :: Preferences, defect, P5)

Product:
Toolkit
Component:
Preferences
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: myk)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])

Attachments

(1 file)

clear prefs that the beforeaccept test sets
1.29 KB, patch
enndeakin
: review+
Details | Diff | Splinter Review
Filed by: apavel [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=154160867&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/WIbsaxNUQIaHe3QR5AvWsg/runs/0/artifacts/public/logs/live_backing.log [task 2018-01-04T18:41:19.589Z] 18:41:19 INFO - TEST-START | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul [task 2018-01-04T18:41:19.771Z] 18:41:19 INFO - TEST-INFO | started process screentopng [task 2018-01-04T18:41:20.434Z] 18:41:20 INFO - TEST-INFO | screentopng: exit 0 [task 2018-01-04T18:41:20.435Z] 18:41:20 INFO - Buffered messages logged at 18:41:19 [task 2018-01-04T18:41:20.436Z] 18:41:20 INFO - TEST-PASS | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | dialog opened, shown pref set [task 2018-01-04T18:41:20.438Z] 18:41:20 INFO - Buffered messages finished [task 2018-01-04T18:41:20.438Z] 18:41:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref not committed - got true, expected null [task 2018-01-04T18:41:20.438Z] 18:41:20 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 [task 2018-01-04T18:41:20.439Z] 18:41:20 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:22:7 [task 2018-01-04T18:41:20.439Z] 18:41:20 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:20:7 [task 2018-01-04T18:41:20.439Z] 18:41:20 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 [task 2018-01-04T18:41:20.439Z] 18:41:20 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-01-04T18:41:20.439Z] 18:41:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | beforeaccept not yet called - got true, expected null [task 2018-01-04T18:41:20.439Z] 18:41:20 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 [task 2018-01-04T18:41:20.440Z] 18:41:20 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:23:7 [task 2018-01-04T18:41:20.441Z] 18:41:20 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:20:7 [task 2018-01-04T18:41:20.442Z] 18:41:20 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 [task 2018-01-04T18:41:20.443Z] 18:41:20 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-01-04T18:41:20.444Z] 18:41:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | beforeaccept not yet called, pref not committed - got true, expected null [task 2018-01-04T18:41:20.446Z] 18:41:20 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 [task 2018-01-04T18:41:20.446Z] 18:41:20 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:24:7 [task 2018-01-04T18:41:20.447Z] 18:41:20 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:20:7 [task 2018-01-04T18:41:20.447Z] 18:41:20 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 [task 2018-01-04T18:41:20.448Z] 18:41:20 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-01-04T18:41:20.448Z] 18:41:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | window not closed - got true, expected false [task 2018-01-04T18:41:20.449Z] 18:41:20 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 [task 2018-01-04T18:41:20.449Z] 18:41:20 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:28:7 [task 2018-01-04T18:41:20.450Z] 18:41:20 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:20:7 [task 2018-01-04T18:41:20.450Z] 18:41:20 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 [task 2018-01-04T18:41:20.451Z] 18:41:20 INFO - TEST-PASS | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref still set [task 2018-01-04T18:41:20.451Z] 18:41:20 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-01-04T18:41:20.452Z] 18:41:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref still not committed - got true, expected null [task 2018-01-04T18:41:20.452Z] 18:41:20 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 [task 2018-01-04T18:41:20.453Z] 18:41:20 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:30:7 [task 2018-01-04T18:41:20.453Z] 18:41:20 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:20:7 [task 2018-01-04T18:41:20.454Z] 18:41:20 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 [task 2018-01-04T18:41:20.454Z] 18:41:20 INFO - TEST-PASS | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | beforeaccept called [task 2018-01-04T18:41:20.455Z] 18:41:20 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-01-04T18:41:20.455Z] 18:41:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | called pref not committed - got true, expected null [task 2018-01-04T18:41:20.456Z] 18:41:20 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 [task 2018-01-04T18:41:20.456Z] 18:41:20 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:32:7 [task 2018-01-04T18:41:20.457Z] 18:41:20 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:20:7 [task 2018-01-04T18:41:20.457Z] 18:41:20 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 [task 2018-01-04T18:41:20.458Z] 18:41:20 INFO - TEST-PASS | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | window now closed [task 2018-01-04T18:41:20.458Z] 18:41:20 INFO - TEST-PASS | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref committed [task 2018-01-04T18:41:20.459Z] 18:41:20 INFO - TEST-PASS | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | called pref committed [task 2018-01-04T18:41:20.460Z] 18:41:20 INFO - GECKO(4893) | MEMORY STAT | vsize 20973805MB | residentFast 996MB [task 2018-01-04T18:41:20.461Z] 18:41:20 INFO - TEST-OK | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | took 254ms [task 2018-01-04T18:41:20.948Z] 18:41:20 INFO - TEST-START | Shutdown [task 2018-01-04T18:41:20.949Z] 18:41:20 INFO - Passed: 18 [task 2018-01-04T18:41:20.950Z] 18:41:20 INFO - Failed: 6 [task 2018-01-04T18:41:20.958Z] 18:41:20 INFO - Todo: 0 [task 2018-01-04T18:41:20.960Z] 18:41:20 INFO - Mode: non-e10s [task 2018-01-04T18:41:20.962Z] 18:41:20 INFO - Slowest: 1231ms - chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul [task 2018-01-04T18:41:20.964Z] 18:41:20 INFO - TEST-INFO | Ran 2 Loops [task 2018-01-04T18:41:20.965Z] 18:41:20 INFO - SimpleTest FINISHED [task 2018-01-04T18:41:21.837Z] 18:41:21 INFO - GECKO(4893) | *** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping [task 2018-01-04T18:41:22.076Z] 18:41:22 INFO - GECKO(4893) | 1515091282067 Marionette DEBUG Received observer notification "xpcom-shutdown" [task 2018-01-04T18:41:22.078Z] 18:41:22 INFO - GECKO(4893) | 1515091282067 Marionette DEBUG New connections will no longer be accepted [task 2018-01-04T18:41:24.029Z] 18:41:24 INFO - GECKO(4893) | ----------------------------------------------------- [task 2018-01-04T18:41:24.033Z] 18:41:24 INFO - GECKO(4893) | Suppressions used: [task 2018-01-04T18:41:24.033Z] 18:41:24 INFO - GECKO(4893) | count bytes template [task 2018-01-04T18:41:24.038Z] 18:41:24 INFO - GECKO(4893) | 693 22088 nsComponentManagerImpl [task 2018-01-04T18:41:24.038Z] 18:41:24 INFO - GECKO(4893) | 45 7920 mozJSComponentLoader::LoadModule [task 2018-01-04T18:41:24.038Z] 18:41:24 INFO - GECKO(4893) | 611 17509 libfontconfig.so [task 2018-01-04T18:41:24.038Z] 18:41:24 INFO - GECKO(4893) | ----------------------------------------------------- [task 2018-01-04T18:41:24.237Z] 18:41:24 INFO - TEST-INFO | Main app process: exit 0 [task 2018-01-04T18:41:24.238Z] 18:41:24 INFO - runtests.py | Application ran for: 0:00:16.426942 [task 2018-01-04T18:41:24.238Z] 18:41:24 INFO - zombiecheck | Reading PID log: /tmp/tmpO3Qkgkpidlog [task 2018-01-04T18:41:24.239Z] 18:41:24 INFO - ==> process 4893 launched child process 4916 [task 2018-01-04T18:41:24.240Z] 18:41:24 INFO - zombiecheck | Checking for orphan process with PID: 4916 [task 2018-01-04T18:41:24.240Z] 18:41:24 INFO - Stopping web server [task 2018-01-04T18:41:24.262Z] 18:41:24 INFO - Stopping web socket server [task 2018-01-04T18:41:24.282Z] 18:41:24 INFO - Stopping ssltunnel [task 2018-01-04T18:41:24.303Z] 18:41:24 WARNING - leakcheck | refcount logging is off, so leaks can't be detected! [task 2018-01-04T18:41:24.304Z] 18:41:24 INFO - runtests.py | Running tests: end. [task 2018-01-04T18:41:24.373Z] 18:41:24 INFO - Buffered messages finished [task 2018-01-04T18:41:24.375Z] 18:41:24 INFO - 0 INFO TEST-START | Shutdown [task 2018-01-04T18:41:24.376Z] 18:41:24 INFO - 1 INFO Passed: 30 [task 2018-01-04T18:41:24.378Z] 18:41:24 INFO - 2 INFO Failed: 6 [task 2018-01-04T18:41:24.379Z] 18:41:24 INFO - 3 INFO Todo: 0 [task 2018-01-04T18:41:24.381Z] 18:41:24 INFO - 4 INFO Mode: non-e10s [task 2018-01-04T18:41:24.382Z] 18:41:24 INFO - 5 INFO SimpleTest FINISHED [task 2018-01-04T18:41:24.383Z] 18:41:24 INFO - Buffered messages finished [task 2018-01-04T18:41:24.384Z] 18:41:24 INFO - SUITE-END | took 22s [task 2018-01-04T18:41:24.385Z] 18:41:24 INFO - SUITE-START | Running 1 tests [task 2018-01-04T18:41:24.386Z] 18:41:24 INFO - ::: [task 2018-01-04T18:41:24.388Z] 18:41:24 INFO - ::: Test verification summary for: [task 2018-01-04T18:41:24.389Z] 18:41:24 INFO - ::: [task 2018-01-04T18:41:24.390Z] 18:41:24 INFO - ::: toolkit/content/tests/chrome/test_preferences_beforeaccept.xul [task 2018-01-04T18:41:24.391Z] 18:41:24 INFO - ::: [task 2018-01-04T18:41:24.392Z] 18:41:24 INFO - ::: 1. Run each test 10 times in one browser. : FAIL [task 2018-01-04T18:41:24.393Z] 18:41:24 INFO - ::: 2. Run each test 5 times in a new browser each time. : not run / incomplete [task 2018-01-04T18:41:24.394Z] 18:41:24 INFO - ::: 3. Run each test 10 times in one browser, in chaos mode. : not run / incomplete [task 2018-01-04T18:41:24.395Z] 18:41:24 INFO - ::: 4. Run each test 5 times in a new browser each time, in chaos mode. : not run / incomplete [task 2018-01-04T18:41:24.396Z] 18:41:24 INFO - ::: [task 2018-01-04T18:41:24.397Z] 18:41:24 INFO - ::: Test verification FAILED! [task 2018-01-04T18:41:24.398Z] 18:41:24 INFO - ::: [task 2018-01-04T18:41:24.399Z] 18:41:24 INFO - Buffered messages finished [task 2018-01-04T18:41:24.400Z] 18:41:24 INFO - SUITE-END | took 0s
Summary: Intermittent toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref not committed - got true, expected null → Perma test-verify toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref not committed - got true, expected null
There have been 67 failures since yesterday (January 4th) when the bug was filed. Failures per platform: - 19 on Linux x64 - 17 on windows10-64 - 15 on Windows 7 - 10 on OS X 10.10 - 2 on windows7-32-nightly - 2 on linux64-nightly - 2 on macosx64-nightly Failures per build type: - 28 on opt - 19 on debug - 15 on pgo - 5 on asan Here is a recent relevant log file: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=154339129&lineNumber=4952 And a snippet with the failure: [task 2018-01-05T11:02:11.674Z] 11:02:11 INFO - TEST-START | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul 4936 [task 2018-01-05T11:02:12.744Z] 11:02:12 INFO - GECKO(4447) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration. 4937 [task 2018-01-05T11:02:12.745Z] 11:02:12 INFO - GECKO(4447) | MEMORY STAT | vsize 1991MB | residentFast 301MB | heapAllocated 121MB 4938 [task 2018-01-05T11:02:12.762Z] 11:02:12 INFO - TEST-OK | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | took 1090ms 4939 [task 2018-01-05T11:02:12.787Z] 11:02:12 INFO - TEST-START | Shutdown 4940 [task 2018-01-05T11:02:12.789Z] 11:02:12 INFO - Passed: 12 4941 [task 2018-01-05T11:02:12.792Z] 11:02:12 INFO - Failed: 0 4942 [task 2018-01-05T11:02:12.793Z] 11:02:12 INFO - Todo: 0 4943 [task 2018-01-05T11:02:12.794Z] 11:02:12 INFO - Mode: non-e10s 4944 [task 2018-01-05T11:02:12.796Z] 11:02:12 INFO - Slowest: 1090ms - chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul 4945 [task 2018-01-05T11:02:12.797Z] 11:02:12 INFO - SimpleTest START Loop 2 4946 [task 2018-01-05T11:02:12.799Z] 11:02:12 INFO - TEST-START | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul 4947 [task 2018-01-05T11:02:12.857Z] 11:02:12 INFO - TEST-INFO | started process screentopng 4948 [task 2018-01-05T11:02:13.307Z] 11:02:13 INFO - TEST-INFO | screentopng: exit 0 4949 [task 2018-01-05T11:02:13.310Z] 11:02:13 INFO - Buffered messages logged at 11:02:12 4950 [task 2018-01-05T11:02:13.311Z] 11:02:13 INFO - TEST-PASS | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | dialog opened, shown pref set 4951 [task 2018-01-05T11:02:13.314Z] 11:02:13 INFO - Buffered messages finished 4952 [task 2018-01-05T11:02:13.316Z] 11:02:13 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | shown pref not committed - got true, expected null 4953 [task 2018-01-05T11:02:13.319Z] 11:02:13 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 4954 [task 2018-01-05T11:02:13.320Z] 11:02:13 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:22:7 4955 [task 2018-01-05T11:02:13.323Z] 11:02:13 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:22:7 4956 [task 2018-01-05T11:02:13.324Z] 11:02:13 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 4957 [task 2018-01-05T11:02:13.325Z] 11:02:13 INFO - Not taking screenshot here: see the one that was previously logged 4958 [task 2018-01-05T11:02:13.326Z] 11:02:13 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_preferences_beforeaccept.xul | beforeaccept not yet called - got true, expected null 4959 [task 2018-01-05T11:02:13.327Z] 11:02:13 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5 4960 [task 2018-01-05T11:02:13.328Z] 11:02:13 INFO - windowOnload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul:23:7 4961 [task 2018-01-05T11:02:13.330Z] 11:02:13 INFO - onDialogLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:22:7 4962 [task 2018-01-05T11:02:13.331Z] 11:02:13 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/window_preferences_beforeaccept.xul:1:1 4963 [task 2018-01-05T11:02:13.332Z] 11:02:13 INFO - Not taking screenshot here: see the one that was previously logged
Flags: needinfo?(enndeakin)
Whiteboard: [stockwell needswork]
Likely related to 1379338.
Blocks: 1379338
Flags: needinfo?(enndeakin) → needinfo?(myk)
cool, bug 1379338 was fixed today, so I would expect to see fewer failures here or something we can do here to take action.
Bug 1379338 may have made this failure permanent, which might make this bug easier to fix, although it's also possible that the intermittent failure will return after the perma-failure has been addressed. In any case, I can reproduce locally, so I'll tackle the perma-failure.
Assignee: nobody → myk
(In reply to Myk Melez [:myk] [@mykmelez] from comment #5) > Bug 1379338 may have made this failure permanent, which might make this bug > easier to fix, although it's also possible that the intermittent failure > will return after the perma-failure has been addressed. Erm, never mind, this was first filed yesterday, and although it was filed as intermittent, it was presumably permanent from the start. > In any case, I can reproduce locally, so I'll tackle the perma-failure. After staring at the code for a while and doing some research, I think this is actually a regression from bug 1056851, which was somehow masked by a bug in preferences.xml that I fixed when I replaced that file in bug 1379338. test_preferences_beforeaccept.xul used to call clearUserPref on both the pref that it set with setBoolPref (browser.preferences.instantApply) and the two prefs that get set by window_preferences_beforeaccept.xul (tests.beforeaccept.dialogShown and tests.beforeaccept.called): > SimpleTest.registerCleanupFunction(() => { > SpecialPowers.clearUserPref("browser.preferences.instantApply"); > SpecialPowers.clearUserPref("tests.beforeaccept.dialogShown"); > SpecialPowers.clearUserPref("tests.beforeaccept.called"); > }); - https://hg.mozilla.org/mozilla-central/file/f331b33c345d/toolkit/content/tests/chrome/test_preferences_beforeaccept.xul Bug 1056851 removed all three clearUserPref calls in favor of setting browser.preferences.instantApply via pushPrefEnv: >+ SpecialPowers.pushPrefEnv({"set":[["browser.preferences.instantApply", false]]}, function() { > > // No instant-apply for this test >- SpecialPowers.setBoolPref("browser.preferences.instantApply", false); >- > var prefWindow = openDialog("window_preferences_beforeaccept.xul", "", "", windowOnload); > >- SimpleTest.registerCleanupFunction(() => { >- SpecialPowers.clearUserPref("browser.preferences.instantApply"); >- SpecialPowers.clearUserPref("tests.beforeaccept.dialogShown"); >- SpecialPowers.clearUserPref("tests.beforeaccept.called"); >- }); - https://hg.mozilla.org/mozilla-central/rev/cb099675e6a5#l78.1 But tests.beforeaccept.dialogShown and tests.beforeaccept.called aren't set by pushPrefEnv, so at that point they stopped getting cleared. I'm not sure why that didn't trigger a test failure, but presumably there was a bug in preferences.xml that caused the changes to those preferences not to get persisted as expected, so not clearing them didn't cause a test failure. Bug 1379338 replaced preferences.xml with preferencesBindings.js, which does persist those values as expected, and that has uncovered this regression. Since the prefs aren't cleared, they're set for the second (and subsequent runs), which is why running the test multiple times (against the same profile) succeeds the first time and then fails on subsequent runs. The fix here is straightforward: reintroduce the cleanup function that clears the tests.beforeaccept.dialogShown and tests.beforeaccept.called preferences after each test run. (I didn't try to find the bug in preferences.xml, because that seems unnecessary, given that the file has been removed, and its replacement is behaving as expected: persisting the changes to the preferences after the dialog is closed.)
Flags: needinfo?(myk)
Attachment #8940358 - Flags: review?(enndeakin)
Blocks: 1056851
Attachment #8940358 - Flags: review?(enndeakin) → review+
Pushed by myk@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/688c7cfe35d2 clear prefs that the beforeaccept test sets; r=enndeakin
https://hg.mozilla.org/mozilla-central/rev/688c7cfe35d2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: