1428229 - Remove FakeString and NotNull member initializations

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

In bug 1406820, initializations were added for members of classes that left them out for optimization reasons. These should be removed.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1428229 - Partial backout a4094a8fa08d (bug 1406820) due to optimization removals;

Review commit: https://reviewboard.mozilla.org/r/210616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210616/

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1428229 - Add comments about purposefully uninitialized variables in BindingDeclarations;

Review commit: https://reviewboard.mozilla.org/r/210618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210618/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8940344 [details]
Bug 1428229 - Partial backout a4094a8fa08d (bug 1406820) due to optimization removals;

https://reviewboard.mozilla.org/r/210616/#review216342

::: dom/bindings/BindingDeclarations.h:348
(Diff revision 1)
>  
>  template<>
>  class Optional<nsAString>
>  {
>  public:
> -  Optional()
> +  Optional() : mPassed(false) {}

Actually, these changes are probably ok.  mPassed really is redundant with mStr...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8940345 [details]
Bug 1428229 - Add comments about purposefully uninitialized variables in BindingDeclarations;

https://reviewboard.mozilla.org/r/210618/#review216344

Thank you!

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8940344 [details]
Bug 1428229 - Partial backout a4094a8fa08d (bug 1406820) due to optimization removals;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210616/diff/1-2/

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8940345 [details]
Bug 1428229 - Add comments about purposefully uninitialized variables in BindingDeclarations;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210618/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58d3a80ef7f7
Partial backout a4094a8fa08d (bug 1406820) due to optimization removals; r=bz
https://hg.mozilla.org/integration/autoland/rev/98a6f537336d
Add comments about purposefully uninitialized variables in BindingDeclarations; r=bz

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/98a6f537336d