Closed Bug 1428229 Opened 2 years ago Closed 2 years ago

Remove FakeString and NotNull member initializations

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

Details

Attachments

(2 files)

In bug 1406820, initializations were added for members of classes that left them out for optimization reasons. These should be removed.
Comment on attachment 8940344 [details]
Bug 1428229 - Partial backout a4094a8fa08d (bug 1406820) due to optimization removals;

https://reviewboard.mozilla.org/r/210616/#review216342

::: dom/bindings/BindingDeclarations.h:348
(Diff revision 1)
>  
>  template<>
>  class Optional<nsAString>
>  {
>  public:
> -  Optional()
> +  Optional() : mPassed(false) {}

Actually, these changes are probably ok.  mPassed really is redundant with mStr...
Attachment #8940344 - Flags: review?(bzbarsky) → review+
Comment on attachment 8940345 [details]
Bug 1428229 - Add comments about purposefully uninitialized variables in BindingDeclarations;

https://reviewboard.mozilla.org/r/210618/#review216344

Thank you!
Attachment #8940345 - Flags: review?(bzbarsky) → review+
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58d3a80ef7f7
Partial backout a4094a8fa08d (bug 1406820) due to optimization removals; r=bz
https://hg.mozilla.org/integration/autoland/rev/98a6f537336d
Add comments about purposefully uninitialized variables in BindingDeclarations; r=bz
https://hg.mozilla.org/mozilla-central/rev/98a6f537336d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.