Closed Bug 1428258 Opened 2 years ago Closed 2 years ago

Move nsIFile::GetNativePath to a different interface (or remove it entirely)

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

(Keywords: addon-compat)

Attachments

(6 files)

+++ This bug was initially created as a clone of Bug #685236 +++

nsIFile::GetNativePath is a footgun, because it returns a char* and that breaks on Unicode paths.

We should move it to a new interface (nsIFileTotallyUnsafeYouShouldntUseIt) or remove it entirely if it's possible.
Comment on attachment 8949025 [details]
Bug 1428258 - Stop using GetNativePath in url-classifier.

https://reviewboard.mozilla.org/r/218424/#review224352
Attachment #8949025 - Flags: review?(dtownsend) → review+
Comment on attachment 8949026 [details]
Bug 1428258 - Stop using GetNativePath in nsAppRunner.cpp.

https://reviewboard.mozilla.org/r/218426/#review224354
Attachment #8949026 - Flags: review?(dtownsend) → review+
Comment on attachment 8949024 [details]
Bug 1428258 - Stop using GetNativePath in chrome/.

https://reviewboard.mozilla.org/r/218422/#review224890
Attachment #8949024 - Flags: review?(honzab.moz) → review+
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 8950897 [details]
Bug 1428258 - Stop using GetNativePath in gfx/.

https://reviewboard.mozilla.org/r/220152/#review226046
Attachment #8950897 - Flags: review?(jmuizelaar) → review+
Depends on: 1428568
Comment on attachment 8952183 [details]
Bug 1428258 - Disallow nsIFile::GetNativePath on Windows.

https://reviewboard.mozilla.org/r/221426/#review227236

Thank you!
Attachment #8952183 - Flags: review?(nfroyd) → review+
Comment on attachment 8950898 [details]
Bug 1428258 - Stop using GetNativePath in Telemetry.cpp.

https://reviewboard.mozilla.org/r/220154/#review227880

Stealing the review from :gfritzsche before :) This looks good to me!
Attachment #8950898 - Flags: review+
Attachment #8950898 - Flags: review?(gfritzsche)
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/ffa5068067a7
Stop using GetNativePath in chrome/. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/c87bbb86f843
Stop using GetNativePath in url-classifier. r=mossop
https://hg.mozilla.org/integration/autoland/rev/3089af2474ef
Stop using GetNativePath in nsAppRunner.cpp. r=mossop
https://hg.mozilla.org/integration/autoland/rev/e3b034c3ac97
Stop using GetNativePath in gfx/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e28a37787c93
Stop using GetNativePath in Telemetry.cpp. r=Dexter
https://hg.mozilla.org/integration/autoland/rev/ee1367eae850
Disallow nsIFile::GetNativePath on Windows. r=froydnj
Ah, THIS ONE breaks comm-central build.
Flags: needinfo?(VYV03354)
See bug 1440278.
Depends on: 1440278
Flags: needinfo?(VYV03354)
Depends on: 1441112
Depends on: 1442746
You need to log in before you can comment on or make changes to this bug.