1428272 - Handle ExternalImage lock failure

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

It is already added to WebRender by https://github.com/servo/webrender/pull/1668 , but it is not used by gecko.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Handle ExternalImage lock failure

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8940087 [details] [diff] [review]
patch - Handle ExternalImage lock failure

Review of attachment 8940087 [details] [diff] [review]:
-----------------------------------------------------------------

In failure cases, we return RawDataToWrExternalImage(nullptr, 0) in RenderBufferTextureHost::Lock and RenderSharedSurfaceTextureHost::Lock, and NativeTextureToWrExternalImage(0, 0, 0, 0, 0) in RenderDXGITextureHostOGL::Lock and RenderMacIOSurfaceTextureHostOGL::Lock. We may wish to switch to InvalidToWrExternalImage() instead to be consistent.

Comment 3

[Sotaro Ikeda [:sotaro]]

Thanks for the comment, I am going to update the patch.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Handle ExternalImage lock failure

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Handle ExternalImage lock failure

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e934a8fad18beae20a12e2368f28f6c24afddfa

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a4c7d5443ab
Handle ExternalImage lock failure r=nical

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4a4c7d5443ab