1428274 - Activity Stream does not update content on 204

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Giorgos Logiotatidis [:giorgos]]

It appears that AS will not update content when the response from the snippets service is 204 No-Content, despite accepting the response and saving the last-update-time. This results to older content being displayed, if available.

A work-around [0] has been placed on the snippets service to return 200-OK with empty content instead, so this is not high priority but I'd like to see it fixed.

Maybe a 205-Reset Content is more appropriate, to reset == set snippets content to default which is empty.


[0] https://github.com/mozmeao/snippets-service/pull/337

Comment 1

[Ed Lee :Mardak]

This should be fixed as part of the switch to message center bug 1432588, so it would be good to verify that this gets fixed then.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4166

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/d99e0ff0c53a7d412328801cf80a869e8269b1af
Bug 1428274 - AS Router should handle 204, 302, 500 codes approrpiately

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

For the record, a stray commit message was left on bug 428274 due to a typo. Pasting it here for completeness:

> Commit pushed to master at https://github.com/mozilla/activity-stream
> 
> https://github.com/mozilla/activity-stream/commit/
> a6958e96fd93397d4953129b33ba2a93ec7b15bb
> Merge pull request #4166 from k88hudson/bug428274
> 
> Bug 1428274 - AS Router should handle 204, 302, 500 codes approrpiately

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/609a288fe314