1428334 - Navigating on about:telemetry frequently opens data:application/json;base64 tabs

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Johann Hofmann [:johannh]]

On Nightly 59, when I visit about:telemetry or click on links on the site, a new tab frequently opens in the foreground containing what seems to be a json dump of my telemetry ping data.

It's a bit annoying to navigate about:telemetry as a consequence :)

Comment 1

[Chris H-C :chutten]

Weird. It should only do that when it encounters an error. Is there something in the log of the about:telemetry tab?

Comment 2

[Chris H-C :chutten]

Could this be fallout from your recent changes, Jeremy?

Comment 3

[Jeremy Lempereur [:o0ignition0o]]

Hmm, might be, could you please assign me ?

Comment 4

[Jeremy Lempereur [:o0ignition0o]]

Attachment: Bug 1428334 - Navigating on about:telemetry frequently opens data:application/json;base64 tabs

Refactored a call to ChromeHangs.render() I forgot while fixing the "Show raw stack data" link (Bug 1427484).

Review commit: https://reviewboard.mozilla.org/r/210560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210560/

Comment 5

[Chris H-C :chutten]

Comment on attachment 8940260 [details]
Bug 1428334 - Navigating on about:telemetry frequently opens data:application/json;base64 tabs

https://reviewboard.mozilla.org/r/210560/#review216234

Comment 6

[Chris H-C :chutten]

Looks like a quick fix. I've sent it to autoland so it should be good for the weekend's builds of Nightly.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28009c663a1d
Navigating on about:telemetry frequently opens data:application/json;base64 tabs r=chutten

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/28009c663a1d