Closed
Bug 1428353
Opened 6 years ago
Closed 6 years ago
Assertion failure: parent || !aContent->GetParent() (no non-elements), at /builds/worker/workspace/build/src/layout/base/nsFrameManager.cpp:138
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox57 | --- | wontfix |
| firefox58 | --- | wontfix |
| firefox59 | --- | fixed |
People
(Reporter: jkratzer, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
Testcase found while fuzzing mozilla-central rev f78a83244fbe. OS|Linux|0.0.0 Linux 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 CPU|amd64|family 6 model 78 stepping 3|1 GPU||| Crash|SIGSEGV|0x0|0 0|0|libxul.so|nsFrameManager::ParentForUndisplayedMap|hg:hg.mozilla.org/mozilla-central:layout/base/nsFrameManager.cpp:f78a83244fbe|138|0x18 0|1|libxul.so|nsFrameManager::GetUndisplayedNodeInMapFor|hg:hg.mozilla.org/mozilla-central:layout/base/nsFrameManager.cpp:f78a83244fbe|166|0xb 0|2|libxul.so|nsFrameManager::GetStyleContextInMap|hg:hg.mozilla.org/mozilla-central:layout/base/nsFrameManager.cpp:f78a83244fbe|150|0x5 0|3|libxul.so|nsFrameSelection::GetFrameForNodeOffset|hg:hg.mozilla.org/mozilla-central:layout/base/nsFrameManager.h:f78a83244fbe|127|0x8 0|4|libxul.so|mozilla::dom::Selection::GetSelectionEndPointGeometry|hg:hg.mozilla.org/mozilla-central:dom/base/Selection.cpp:f78a83244fbe|3503|0x1c 0|5|libxul.so|mozilla::dom::Selection::GetSelectionAnchorGeometry|hg:hg.mozilla.org/mozilla-central:dom/base/Selection.cpp:f78a83244fbe|3437|0x5 0|6|libxul.so|mozilla::dom::Selection::ScrollIntoView|hg:hg.mozilla.org/mozilla-central:dom/base/Selection.cpp:f78a83244fbe|3663|0xf 0|7|libxul.so|mozilla::dom::Selection::ScrollSelectionIntoViewEvent::Run|hg:hg.mozilla.org/mozilla-central:dom/base/Selection.cpp:f78a83244fbe|3557|0x13 0|8|libxul.so|nsRefreshDriver::Tick|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:f78a83244fbe|1831|0x3 0|9|libxul.so|mozilla::RefreshDriverTimer::TickRefreshDrivers|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:f78a83244fbe|306|0xf 0|10|libxul.so|mozilla::RefreshDriverTimer::Tick|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:f78a83244fbe|328|0x12 0|11|libxul.so|mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:f78a83244fbe|769|0x5 0|12|libxul.so|mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:f78a83244fbe|583|0xc 0|13|libxul.so|mozilla::layout::VsyncChild::RecvNotify|hg:hg.mozilla.org/mozilla-central:layout/ipc/VsyncChild.cpp:f78a83244fbe|68|0x9 0|14|libxul.so|mozilla::layout::PVsyncChild::OnMessageReceived|s3:gecko-generated-sources:06086093ccb59dd5a99cf8c9f9fb7f4860fd8ddbfd516af5e5b3508be62029679421dcf2abdf6b1c945b6a054050bd403c9574aad49f857cb4a31d3f4cf56b9a/ipc/ipdl/PVsyncChild.cpp:|155|0xf 0|15|libxul.so|mozilla::ipc::MessageChannel::DispatchAsyncMessage|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:f78a83244fbe|2110|0x6 0|16|libxul.so|mozilla::ipc::MessageChannel::DispatchMessage|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:f78a83244fbe|2040|0xb 0|17|libxul.so|mozilla::ipc::MessageChannel::RunMessage|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:f78a83244fbe|1886|0xb 0|18|libxul.so|mozilla::ipc::MessageChannel::MessageTask::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:f78a83244fbe|1919|0xc 0|19|libxul.so|nsThread::ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:f78a83244fbe|1040|0x15 0|20|libxul.so|NS_ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:f78a83244fbe|510|0x11 0|21|libxul.so|mozilla::ipc::MessagePump::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:f78a83244fbe|125|0xd 0|22|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f78a83244fbe|326|0x17 0|23|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f78a83244fbe|319|0x8 0|24|libxul.so|nsBaseAppShell::Run|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:f78a83244fbe|157|0xd 0|25|libxul.so|XRE_RunAppShell|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:f78a83244fbe|875|0x11 0|26|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:f78a83244fbe|269|0x5 0|27|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f78a83244fbe|326|0x17 0|28|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f78a83244fbe|319|0x8 0|29|libxul.so|XRE_InitChildProcess|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:f78a83244fbe|701|0x8 0|30|firefox|content_process_main|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:f78a83244fbe|63|0x14 0|31|firefox|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:f78a83244fbe|280|0x11 0|32|libc-2.23.so||||0x20830 0|33|firefox|MOZ_ReportAssertionFailure|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:f78a83244fbe|165|0x5
Flags: in-testsuite?
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
Maybe that assertion is too strict? Why should GetDisplayContentsStyleFor(aNode) be an invalid call when aNode is not in the document? aNode->GetPrimaryFrame() is valid, so it seems GetDisplayContentsStyleFor should be too.
Flags: needinfo?(emilio)
| Comment hidden (mozreview-request) |
|
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940294 [details] Bug 1428353: Allow undisplayed maps to be queried for elements out of the document. https://reviewboard.mozilla.org/r/210590/#review216430
Attachment #8940294 -
Flags: review?(mats) → review+
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9fd84f164c7f Allow undisplayed maps to be queried for elements out of the document. r=mats
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9fd84f164c7f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
Assignee: nobody → emilio
status-firefox57:
--- → wontfix
status-firefox58:
--- → wontfix
status-firefox-esr52:
--- → unaffected
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•