1428371 - GeckoView example app crashes on startup with multiprocess enabled

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Eugen Sawin [:esawin]]

With multiprocess enabled, the example app crashes on startup before page load.
Regression from bug 1409113.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1428371-1.0-Add-missing-member-initialization-in.patch

InputContext::mHasHandlerUserInput appears to be uninitialized when accessed in GeckoEditableSupport::SetInputContext, which signals an erroneous user action.

Comment 2

[Eugen Sawin [:esawin]]

Bob, can you please verify that Autophone runs with e10s enabled? I'm surprised not to see the regression there.

Comment 3

[Bob Clary [:bc] (inactive)]

A[tier 2](tg)
<https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=autophone&group_state=expanded&selectedJob=154987184>

<https://autophone.s3.amazonaws.com/v1/task/Q2a0oBwcSjeWFaCAnlBBQg/runs/0/artifacts/public/build/45f61b49-0deb-4df9-a39c-92556bad6e33-autophone.log>

am start uses --ez use_multiprocess False

A-e10s[tier 2](tg)

<https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=autophone&group_state=expanded&selectedJob=154987195>

<https://autophone.s3.amazonaws.com/v1/task/Q2a0oBwcSjeWFaCAnlBBQg/runs/0/artifacts/public/build/b036df0c-4204-48a7-a86b-ec3683e820b0-autophone.log>

am start uses --ez use_multiprocess True

Is this not correct?

I am getting data:
<http://phonedash.mozilla.org/#/2018-01-08/2018-01-09/binning=repo-phonetype-phoneid-test_name&rejected=norejected&errorbars=noerrorbars&errorbartype=standarderror&valuetype=median&geckoview-e10s-nytimes=on&geckoview-nytimes=on&throbberstart=on&throbberstop=on&throbbertime=on&first=on&second=on&autoland=on&mozilla-beta=on&mozilla-central=on&mozilla-inbound=on&nexus-4=on&nexus-4-09=on&nexus-5=on&nexus-5-03=on&nexus-5-04=on&nexus-5-05=on&nexus-6p=on&nexus-6p-08=on&nexus-6p-10=on&nexus-6p-12=on&nexus-6p-13=on&pixel=on&pixel-02=on&pixel-04=on&pixel-11=on>

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed3d5e1ac862
Add missing member initialization in InputContext. r=masayuki

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ed3d5e1ac862