1428401 - Remove obsolete getPref helpers

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Florian Quèze [:florian]]

We have a few duplicated 'getPref' helpers in the tree that are just wrapping nsIPrefBranch.get*Pref calls with a try/catch to return a default value instead of throwing. This is now supported by default since bug 1338306.

https://searchfox.org/mozilla-central/search?q=getPref(%22get

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

For a change, I haven't created a script to do this for me. It's just a simple search & replace in Emacs with this rule:
getPref("\([^"]+\)",Services.prefs.\1(

And then the indent is fixed by hand, and the functions removed by hand.

Comment 2

[:Gijs (he/him)]

Comment on attachment 8940280 [details] [diff] [review]
Patch

Review of attachment 8940280 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: toolkit/components/timermanager/nsUpdateTimerManager.js
@@ +84,1 @@
>                                               30000), minFirstInterval);

Heh, it's amusing you don't need to adjust this indent.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86318931910b
Remove obsolete getPref helpers, r=Gijs.

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/86318931910b