1428422 - Update go client for r14y

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[Brian Stack [:bstack]]

Explained in bug 1428417.

Comment 1

[Pete Moore [:pmoore][:pete]]

Working on this now.

Comment 2

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for jsonschema2go

Hey Brian,

Previously we had fully qualified URLs in $ref properties - this PR adds support for relative URLs, relative to $id property.

Note, this needs to land before taskcluster/taskcluster-client-go#33.

Thanks!

Comment 3

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-client-go

Note, this PR depends on the previous jsonschema2go PR so the CI for this will fail until the other one lands.

There are 3 commits as follows:

   * The first adds support for relative URLs for schema references
   * The second disables services that seem to have invalid references/schemas - this commit can be reverted when those issues are solved
   * The third commit is for the updated generated code - this does not need to be reviewed in detail, and is the majority of the diff in this PR

Since the majority of the code change is the regenerated code, it is probably best and easiest to simply review the first two commits.

Note, this first PR also does not deal with all redeployability concerns, it is mostly about getting the client generation working again after we needed to introduce backwardly incompatible changes in the service definitions.

The other redeployability changes will follow afterwards when I'm back from PTO.

Many thanks!

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/jsonschema2go

https://github.com/taskcluster/jsonschema2go/commit/20ed11f8128378f71175e747dfc9cb8456a9a750
Bug 1428422 - support relative paths in , relative to  property

https://github.com/taskcluster/jsonschema2go/commit/6ebde322b82c260d467bb7f280a6740c58d3e271
Merge pull request #16 from taskcluster/bug1428422

Bug 1428422 - support relative paths in $ref, relative to property $id

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-client-go

https://github.com/taskcluster/taskcluster-client-go/commit/9deeaf16c714fadcf15f3af8e31d1bcff11f8fa1
Merge pull request #33 from taskcluster/bug1428422_2

Bug 1428422 - Support relative urls for exchange schemas / http input/output schemas and disable failing services

Comment 6

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-client-go

This patch reenables treeherder events code generation after bug 1462769 landed.

Comment 7

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-client-java

This reenables treeherder events code generation for taskcluster-client-java library.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-client-go

https://github.com/taskcluster/taskcluster-client-go/commit/d0f5700ac3c895ecee3b03841a6790d2a7bd2412
Bug 1428422 - reenable treeherder events

https://github.com/taskcluster/taskcluster-client-go/commit/933a1a5060d934dd52277b150a5d7a9d9cf4e407
Merge pull request #35 from taskcluster/bug1428422_3

Bug 1428422 - reenable treeherder events code generation

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-client-java

https://github.com/taskcluster/taskcluster-client-java/commit/7b089aaef4ef8927921f83f4e24eb3b9f7ed5097
Bug 1428422 - reenable treeherder events

https://github.com/taskcluster/taskcluster-client-java/commit/7bb7d4fc804427dd3e30775b80da456dd0257271
Merge pull request #11 from taskcluster/bug1428422

Bug 1428422 - reenable treeherder events code generation

Comment 10

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for taskcluster-client-go

Started work on the next phase, adding RootURL to Credentials struct and associated changes to tests, generated code, creation of http requests etc...

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

I see this linked from https://docs.google.com/document/d/155L2JS5l4Hu5yDLEWHiYNS9ujnBt7-jfXayOrHOaIt8/edit under "Build client generation tool".  Should the subject be changed, perhaps?

Comment 12

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for taskcluster-client-go

This is something of a rework of previous patches, and can be landed independently. This adds full support for downloading manifests/references/schemas as per taskcluster RFC 0128.

There have been several moving pieces in the last months, which is why there were multiple PRs created - I will review the open PRs with earlier attempts at adding this support, to ensure that the concerns they handled are also covered in this new PR, and that any feedback I received is also taken onboard, if it had not yet been addressed.

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-client-go

https://github.com/taskcluster/taskcluster-client-go/commit/61f56a925f6682e86fd741399e48383d41c8b1d6
Bug 1428422 - Update code generation to work with redeployable workers

https://github.com/taskcluster/taskcluster-client-go/commit/3f4d4428000acd6e9f9d0d36e1a2aebd74447bf4
Merge pull request #39 from taskcluster/bug1428422-NEW

Bug 1428422 - Update go client for redeployability

Comment 14

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for generic-worker

Comment 15

[Pete Moore [:pmoore][:pete]]

Comment on attachment 9038877 [details] [review]
GitHub Pull Request for generic-worker

This should be done in bug 1469614 instead.

Comment 16

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/9cd6dd824ccfa1c4816930fa55f34b7d09c96494
Bug 1428422 - use updated taskcluster-client-go in generic-worker

https://github.com/taskcluster/generic-worker/commit/cd0c355df6e2787bbf7bd1e8d4d0a2ffc1bb0ad7
Merge pull request #139 from taskcluster/bug1428422

Bug 1469614 - use updated taskcluster-client-go in generic-worker

Comment 17

[Dustin J. Mitchell [:dustin] (he/him)]

Pete, is this done now?

Comment 18

[Pete Moore [:pmoore][:pete]]

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #17)

Pete, is this done now?

Indeed, thanks for checking!

Comment 19

[Pete Moore [:pmoore][:pete]]

Released in generic-worker 11.1.1.