Support JSOP_GIMPLICITTHIS in IonMonkey

RESOLVED FIXED in Firefox 59

Status

()

Core
JavaScript Engine: JIT
P1
normal
RESOLVED FIXED
16 days ago
3 days ago

People

(Reporter: tcampbell, Assigned: tcampbell)

Tracking

(Blocks: 1 bug)

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

16 days ago
After JSM shared-globals landed (Bug 1186409) devtools is having a sad time and is unable to IonCompile a number of things because of JSOP_GIMPLICITTHIS.

We should at least use a VMCall like baseline does instead of failing to compile.
(Assignee)

Updated

16 days ago
Assignee: nobody → tcampbell
Blocks: 1426034
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Updated

6 days ago
See Also: → bug 1430656
(Assignee)

Comment 2

4 days ago
Comment on attachment 8940464 [details]
Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall.

Support JSOP_IMPLICITTHIS in IonMonkey. This uses same VMCall that Baseline does. Doing this unblocks a number of browser-chrome scripts, particularly in devtools. (As an extreme example, the WasmDis code runs 50% faster).
Attachment #8940464 - Flags: review?(jdemooij)

Comment 3

4 days ago
mozreview-review
Comment on attachment 8940464 [details]
Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall.

https://reviewboard.mozilla.org/r/210708/#review219614

This is excellent.
Attachment #8940464 - Flags: review?(jdemooij) → review+

Comment 4

4 days ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s df6ad59b94fb1e4ee25afce819bb5fcd1ada6996 -d 110b50e49ca4: rebasing 443099:df6ad59b94fb "Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall r=jandem" (tip)
merging js/src/jit/BaselineCompiler.cpp
merging js/src/jit/CodeGenerator.cpp
merging js/src/jit/CodeGenerator.h
merging js/src/jit/IonBuilder.cpp
merging js/src/jit/Lowering.cpp
merging js/src/jit/Lowering.h
merging js/src/jit/MIR.h
merging js/src/jit/MOpcodes.h
merging js/src/jit/shared/LIR-shared.h
merging js/src/jit/shared/LOpcodes-shared.h
warning: conflicts while merging js/src/jit/CodeGenerator.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging js/src/jit/Lowering.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

4 days ago
Rebased manually through Bug 1428535.

Comment 7

4 days ago
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/514350cead8b
Support JSOP_IMPLICITTHIS in Ion using VMCall. r=jandem

Comment 8

3 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/514350cead8b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.