1428489 - Support JSOP_GIMPLICITTHIS in IonMonkey

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[Ted Campbell [:tcampbell]]

After JSM shared-globals landed (Bug 1186409) devtools is having a sad time and is unable to IonCompile a number of things because of JSOP_GIMPLICITTHIS.

We should at least use a VMCall like baseline does instead of failing to compile.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall.

Review commit: https://reviewboard.mozilla.org/r/210708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210708/

Comment 2

[Ted Campbell [:tcampbell]]

Comment on attachment 8940464 [details]
Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall.

Support JSOP_IMPLICITTHIS in IonMonkey. This uses same VMCall that Baseline does. Doing this unblocks a number of browser-chrome scripts, particularly in devtools. (As an extreme example, the WasmDis code runs 50% faster).

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8940464 [details]
Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall.

https://reviewboard.mozilla.org/r/210708/#review219614

This is excellent.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s df6ad59b94fb1e4ee25afce819bb5fcd1ada6996 -d 110b50e49ca4: rebasing 443099:df6ad59b94fb "Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall r=jandem" (tip)
merging js/src/jit/BaselineCompiler.cpp
merging js/src/jit/CodeGenerator.cpp
merging js/src/jit/CodeGenerator.h
merging js/src/jit/IonBuilder.cpp
merging js/src/jit/Lowering.cpp
merging js/src/jit/Lowering.h
merging js/src/jit/MIR.h
merging js/src/jit/MOpcodes.h
merging js/src/jit/shared/LIR-shared.h
merging js/src/jit/shared/LOpcodes-shared.h
warning: conflicts while merging js/src/jit/CodeGenerator.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging js/src/jit/Lowering.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Ted Campbell [:tcampbell]]

Comment on attachment 8940464 [details]
Bug 1428489 - Support JSOP_IMPLICITTHIS in Ion using VMCall.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210708/diff/1-2/

Comment 6

[Ted Campbell [:tcampbell]]

Rebased manually through Bug 1428535.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/514350cead8b
Support JSOP_IMPLICITTHIS in Ion using VMCall. r=jandem

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/514350cead8b