Closed
Bug 1428507
Opened 6 years ago
Closed 6 years ago
Avoid non-inlinable GCCellPtr constructing during tracing
Categories
(Core :: JavaScript Engine, enhancement, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file, 1 obsolete file)
|
1.27 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
drainMarkStack calls Value::toGCCellPtr, which cannot be inlined.
|
Assignee | |
Comment 1•6 years ago
|
||
Sorry, please ignore the wall of text I just fired at you in the other bug. The spot fix turns out to be trivial.
Attachment #8940382 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Sorry, that totally needed a comment.
Attachment #8940385 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8940382 -
Attachment is obsolete: true
Attachment #8940382 -
Flags: review?(jcoppeard)
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8940385 [details] [diff] [review] Avoid non-inlinable GCCellPtr constructing during tracing Review of attachment 8940385 [details] [diff] [review]: ----------------------------------------------------------------- This is fine, although I don't get why the compiler can't inline this.
Attachment #8940385 -
Flags: review?(jcoppeard) → review+
|
|
||
Comment 4•6 years ago
|
||
(In reply to Jon Coppeard (:jonco) from comment #3) Oh right, this is explained in the comment in the other bug.
|
||
Updated•6 years ago
|
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aec2c9f02876 Avoid non-inlinable GCCellPtr constructing during tracing, r=jonco
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aec2c9f02876
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•