Avoid non-inlinable GCCellPtr constructing during tracing

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

drainMarkStack calls Value::toGCCellPtr, which cannot be inlined.
Sorry, please ignore the wall of text I just fired at you in the other bug. The spot fix turns out to be trivial.
Attachment #8940382 - Flags: review?(jcoppeard)
Sorry, that totally needed a comment.
Attachment #8940385 - Flags: review?(jcoppeard)
Attachment #8940382 - Attachment is obsolete: true
Attachment #8940382 - Flags: review?(jcoppeard)
Comment on attachment 8940385 [details] [diff] [review]
Avoid non-inlinable GCCellPtr constructing during tracing

Review of attachment 8940385 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, although I don't get why the compiler can't inline this.
Attachment #8940385 - Flags: review?(jcoppeard) → review+
(In reply to Jon Coppeard (:jonco) from comment #3)
Oh right, this is explained in the comment in the other bug.
Status: ASSIGNED → NEW
Priority: -- → P1
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aec2c9f02876
Avoid non-inlinable GCCellPtr constructing during tracing, r=jonco
https://hg.mozilla.org/mozilla-central/rev/aec2c9f02876
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.