1428507 - Avoid non-inlinable GCCellPtr constructing during tracing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Steve Fink [:sfink] [:s:]]

drainMarkStack calls Value::toGCCellPtr, which cannot be inlined.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Avoid non-inlinable GCCellPtr constructing during tracing

Sorry, please ignore the wall of text I just fired at you in the other bug. The spot fix turns out to be trivial.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Avoid non-inlinable GCCellPtr constructing during tracing

Sorry, that totally needed a comment.

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 8940385 [details] [diff] [review]
Avoid non-inlinable GCCellPtr constructing during tracing

Review of attachment 8940385 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, although I don't get why the compiler can't inline this.

Comment 4

[Jon Coppeard (:jonco)]

(In reply to Jon Coppeard (:jonco) from comment #3)
Oh right, this is explained in the comment in the other bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aec2c9f02876
Avoid non-inlinable GCCellPtr constructing during tracing, r=jonco

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/aec2c9f02876