Closed Bug 1428695 Opened 7 years ago Closed 7 years ago

there should be tests for the Clear Recent History dialog

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox59 --- affected

People

(Reporter: myk, Unassigned)

References

Details

There should be tests for the Clear Recent History dialog to ensure it continues to work across changes (like bug 1379338, which caused regression 1428529).
Component: Bookmarks & History → General
There are tests for this dialog at https://searchfox.org/mozilla-central/rev/f42618c99dcb522fb674221acfbc68c2d92e7936/browser/base/content/test/general/browser_sanitizeDialog.js I think this bug can be closed and the work intended here should be done in bug 1428529 (I'll leave this open for you to close in case you had other test cases in mind).
Flags: needinfo?(myk)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1) > There are tests for this dialog at > https://searchfox.org/mozilla-central/rev/ > f42618c99dcb522fb674221acfbc68c2d92e7936/browser/base/content/test/general/ > browser_sanitizeDialog.js > > I think this bug can be closed and the work intended here should be done in > bug 1428529 (I'll leave this open for you to close in case you had other > test cases in mind). Agreed. I'm attaching a patch in bug 1428529 to make browser/base/content/test/general/browser_sanitizeDialog.js catch the regression in that bug. I didn't have any other test cases in mind, so I'll close this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(myk)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.