1428727 - Drag and drop can unpin a different topsite than the one being dragged

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Andrei Oprea [:andreio]]

Attachment: att1.png

STR
* Have 6 topsites all pinned
* drag a topsite over the one to its right (will result in an empty gap)

Result
* The empty gap is automatically filled by the topsite that went from position 6 to 7, when this happens it also loses its pinned state.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: att2.png

Comment 2

[Andrei Oprea [:andreio]]

att1 shows initial state. att2 shows how amz when from position 6 to 2 and is now unpinned.

Comment 3

[Ed Lee :Mardak]

Just to be clear, from attachment 8940658 [details] to attachment 8940659 [details], reddit was dragged from the 2nd position to the 3rd position?

uiwanted: What would you expect to happen for:

1) the 2nd position
2) the pinned amazon site?

(The current behavior's reasoning is that because amazon would have been pushed from 6 to 7 with only 6 top sites shown, the user would have a hidden pinned site that couldn't get unpinned, so the code automatically unpins it. In this specific case, amazon is the next top site when there's no frecent sites, but if there had been frecent sites, e.g., mozilla.org, it would have filled in the 2nd position when dragging reddit to the right.)

Comment 4

[Ed Lee :Mardak]

Attachment: drag 2nd to 3rd with only defaults vs with frecent mozilla

Here's a screenshot of what I was describing in comment 3. The reason the 6th pinned default top site appears in the 2nd position is because there's nothing else better to fill in.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3930

Comment 6

[Ed Lee :Mardak]

bryan provided the feedback to move towards the hole

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/eb1becf42a4f92b97878369938f8cf809793366b
Fix Bug 1428727 - better shifting of pinned sites during drag n drop

https://github.com/mozilla/activity-stream/commit/078a9e96f4f8d9dd480980f8721e7781f2039105
Merge pull request #3930 from rlr/bug1428727/dnd-better-algo

Fix Bug 1428727 - better shifting of pinned sites during drag n drop

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8ae1faf4646f

Comment 9

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly build (Build ID 	20180121220252) using Windows 10 x64, Mac 10.12 and Ubuntu 14.04.