1428760 - Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Mark Banner (:standard8)]

I'm currently working on fixing tests for bug 1423896. I noticed that browser_bookmarkProperties_readOnlyRoot.js uses an obsolete API (getItemTitle) so we should clean that up.

It also uses PlacesUIUtils.leftPaneQueries.UnfiledBookmarks which will be removed as well, and that can be changed in advance.

As an added bonus, I also changed is -> Assert.equals, and ok -> Assert.ok as they provide better output for the tests so that you can more easily see what the values are when they pass.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1428760 - Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs.

Review commit: https://reviewboard.mozilla.org/r/210958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210958/

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8940697 [details]
Bug 1428760 - Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs.

https://reviewboard.mozilla.org/r/210958/#review216776

::: browser/components/places/tests/browser/browser_bookmarkProperties_readOnlyRoot.js:36
(Diff revision 1)
> -           "Root title is correct");
>          // Check the shortcut's title.
> -        let bookmark = await PlacesUtils.bookmarks.fetch(tree.selectedNode.bookmarkGuid);
> -        is(bookmark.title, "",
> +        info(tree.selectedNode.bookmarkGuid);
> +        bookmark = await PlacesUtils.bookmarks.fetch(tree.selectedNode.bookmarkGuid);
> +        Assert.equal(bookmark.title, "",
>             "Shortcut title is null");

nit: can be onelined

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8940697 [details]
Bug 1428760 - Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210958/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd18db6ffcb0
Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs. r=mak

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/dd18db6ffcb0