14289 - hitting reload doesn't work.

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[(not reading, please use [e-mail] instead)]

it used to crash, but that's fixed now.

see related bug #14825

Comment 1

[(not reading, please use [e-mail] instead)]

ok, I've checked in a bunch of changes to sidebarOverlay.js

first, sidebarOverlayInit() takes one parameter and in a couple places were we
calling it with two.

I've commented out the code in reloadSidebar()

the code looked like it was trying to find all panels, remove them, and the call
sidebarOverlayInit() to add them back.

instead, it seems to remove the wrong thing, and then when sidebarOverlayInit()
is called, it is unable to add them back.

since its better to have reload not work, than it is to have reload remove the
side bar, I commented the code out.

I also moved some code around so that we only go through the effort of building
up a default sidebar db and resource if they user didn't pass us one.  currently
only navigator.js calls us without one.

slamm, there is a problem with the default sidebar code.  we need to work for
other sidebars, like in mail news.  currently we are assuming that if
sidebarOverlayInit() is called with null, to look in <profile>/sidebar.rdf for
the users sidebar, and if that's not there, use the sidebar.rdf file that comes
with 5.0

that doesn't make sense when called from mail news, as our default sidebar is
messenger-sidebar.rdf

Comment 2

[Steve Lamm]

I had not expected mailnews to switch to the new sidebar layout so soon. I was
taking the params to sidebarOverlayInit() out because there will only be one
list of sidebar panels in the future. Alec added them back in order to get the
folder pane. The folder pane is going to reside outside the sidebar panels (As
soon as hyatt gets back from vacation and we fix overlays).

In the meantime, I will see if I can fix reload.

Comment 3

[Steve Lamm]

Fixed.

Comment 4

[Paul MacQuiddy]

Reload is working now, both for new messages flash and for tinderbox panel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/800860f52ed3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14289: Check if toolbar is initialised before setting flags.