Closed
Bug 1428952
Opened 6 years ago
Closed 6 years ago
Update audioipc to use Tokio for async processing of sockets.
Categories
(Core :: Audio/Video: cubeb, enhancement, P2)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: u480271, Assigned: u480271)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 1 obsolete file)
This is the tokio branch from audioipc-2
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0af4ba765e818ab4776c2fcc6d749dae5b05d722
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
:kinetik, It might be easier to follow the non-collapsed commits to audioipc-2 in the tokio-rebase and tokio-gecko branches.
Flags: needinfo?(kinetik)
|
||
Comment 8•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940934 [details] Bug 1428952 - P4: Vendor rust crates. https://reviewboard.mozilla.org/r/211210/#review217306 r=me with the third_party/rust/*/target/* additions trimmed. Those looks like cruft from test builds and I don't think we need the in the tree?
Attachment #8940934 -
Flags: review?(giles) → review+
|
||
Comment 9•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940930 [details] Bug 1428952 - P1: Update cubeb-pulse-rs to version 864332f. https://reviewboard.mozilla.org/r/211202/#review217320
Attachment #8940930 -
Flags: review?(kinetik) → review+
|
|
||
Comment 10•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940931 [details] Bug 1428952 - P1: Update cubeb-rs to commit aaba6b3. https://reviewboard.mozilla.org/r/211204/#review217322
Attachment #8940931 -
Flags: review?(kinetik) → review+
|
|
||
Comment 11•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940932 [details] Bug 1428952 - P2: Add update.sh for updating audioipc crates. https://reviewboard.mozilla.org/r/211206/#review217324 ::: media/audioipc/update.sh:13 (Diff revision 1) > + test -d $crate/src || mkdir -p $crate/src > + rm -fr $crate/* > + cp -pr $1/$crate/Cargo.toml $crate/ > + cp -pr $1/$crate/src/ $crate/src/ > +done > + Nit: extra whitespace
Attachment #8940932 -
Flags: review?(kinetik) → review+
|
||
Updated•6 years ago
|
Rank: 15
Priority: -- → P2
|
|
||
Updated•6 years ago
|
Flags: needinfo?(kinetik)
|
|
||
Comment 12•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940933 [details] Bug 1428952 - P3: Update to version 0.2.0 of AudioIPC. https://reviewboard.mozilla.org/r/211208/#review219096 Generally LGTM. A few things to fix before landing: - Additions in audioipc/src/rpc seem to have two licenses, should only have the upstream license - Document the upstream repository and version the rpc code was imported from - Document any local changes made to the imported rpc code - Tests in audioipc/src/message.rs are all commented out - either enable, comment with reasoning for disabling, or remove - Roll in the code changes from upstream rather than carrying them in gecko.patch (keep that just for toml/build changes)
Attachment #8940933 -
Flags: review?(kinetik) → review+
|
Assignee | |
Comment 13•6 years ago
|
||
(In reply to Matthew Gregan [:kinetik] from comment #11) > Comment on attachment 8940932 [details] > Bug 1428952 - P3: Add update.sh for updating audioipc crates. > > Nit: extra whitespace Doesn't seem my core.whitespace = trailing-space is working. Fixed.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Attachment #8940930 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 18•6 years ago
|
||
Cleaned up the tokio version of audioipc suggested in #c12. Another bug landed an updated cubeb-pulse-rs so that patch has been removed from the set.
|
||
Comment 19•6 years ago
|
||
Pushed by dglastonbury@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00065e245cfc P1: Update cubeb-rs to commit aaba6b3. r=kinetik https://hg.mozilla.org/integration/autoland/rev/23ba5e1c773f P2: Add update.sh for updating audioipc crates. r=kinetik https://hg.mozilla.org/integration/autoland/rev/5f79f72ac9fe P3: Update to version 0.2.0 of AudioIPC. r=kinetik https://hg.mozilla.org/integration/autoland/rev/33873f5e18b9 P4: Vendor rust crates. r=rillian
|
||
Comment 20•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00065e245cfc https://hg.mozilla.org/mozilla-central/rev/23ba5e1c773f https://hg.mozilla.org/mozilla-central/rev/5f79f72ac9fe https://hg.mozilla.org/mozilla-central/rev/33873f5e18b9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•