1428952 - Update audioipc to use Tokio for async processing of sockets.

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P2)

Description

[u480271]

This is the tokio branch from audioipc-2

Comment 1

[u480271]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0af4ba765e818ab4776c2fcc6d749dae5b05d722

Comment 2

[u480271]

Attachment: Bug 1428952 - P1: Update cubeb-pulse-rs to version 864332f.

Review commit: https://reviewboard.mozilla.org/r/211202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211202/

Comment 3

[u480271]

Attachment: Bug 1428952 - P1: Update cubeb-rs to commit aaba6b3.

Review commit: https://reviewboard.mozilla.org/r/211204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211204/

Comment 4

[u480271]

Attachment: Bug 1428952 - P2: Add update.sh for updating audioipc crates.

Review commit: https://reviewboard.mozilla.org/r/211206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211206/

Comment 5

[u480271]

Attachment: Bug 1428952 - P3: Update to version 0.2.0 of AudioIPC.

Review commit: https://reviewboard.mozilla.org/r/211208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211208/

Comment 6

[u480271]

Attachment: Bug 1428952 - P4: Vendor rust crates.

Review commit: https://reviewboard.mozilla.org/r/211210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211210/

Comment 7

[u480271]

:kinetik, It might be easier to follow the non-collapsed commits to audioipc-2 in the tokio-rebase and tokio-gecko branches.

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8940934 [details]
Bug 1428952 - P4: Vendor rust crates.

https://reviewboard.mozilla.org/r/211210/#review217306

r=me with the third_party/rust/*/target/* additions trimmed. Those looks like cruft from test builds and I don't think we need the in the tree?

Comment 9

[Matthew Gregan [:kinetik]]

Comment on attachment 8940930 [details]
Bug 1428952 - P1: Update cubeb-pulse-rs to version 864332f.

https://reviewboard.mozilla.org/r/211202/#review217320

Comment 10

[Matthew Gregan [:kinetik]]

Comment on attachment 8940931 [details]
Bug 1428952 - P1: Update cubeb-rs to commit aaba6b3.

https://reviewboard.mozilla.org/r/211204/#review217322

Comment 11

[Matthew Gregan [:kinetik]]

Comment on attachment 8940932 [details]
Bug 1428952 - P2: Add update.sh for updating audioipc crates.

https://reviewboard.mozilla.org/r/211206/#review217324

::: media/audioipc/update.sh:13
(Diff revision 1)
> +    test -d $crate/src || mkdir -p $crate/src
> +    rm -fr $crate/*
> +    cp -pr $1/$crate/Cargo.toml $crate/
> +    cp -pr $1/$crate/src/ $crate/src/
> +done
> +             

Nit: extra whitespace

Comment 12

[Matthew Gregan [:kinetik]]

Comment on attachment 8940933 [details]
Bug 1428952 - P3: Update to version 0.2.0 of AudioIPC.

https://reviewboard.mozilla.org/r/211208/#review219096

Generally LGTM.  A few things to fix before landing:

- Additions in audioipc/src/rpc seem to have two licenses, should only have the upstream license
- Document the upstream repository and version the rpc code was imported from
- Document any local changes made to the imported rpc code
- Tests in audioipc/src/message.rs are all commented out - either enable, comment with reasoning for disabling, or remove
- Roll in the code changes from upstream rather than carrying them in gecko.patch (keep that just for toml/build changes)

Comment 13

[u480271]

(In reply to Matthew Gregan [:kinetik] from comment #11)
> Comment on attachment 8940932 [details]
> Bug 1428952 - P3: Add update.sh for updating audioipc crates.         
> 
> Nit: extra whitespace

Doesn't seem my core.whitespace = trailing-space is working.

Fixed.

Comment 14

[u480271]

Comment on attachment 8940931 [details]
Bug 1428952 - P1: Update cubeb-rs to commit aaba6b3.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211204/diff/1-2/

Comment 15

[u480271]

Comment on attachment 8940932 [details]
Bug 1428952 - P2: Add update.sh for updating audioipc crates.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211206/diff/1-2/

Comment 16

[u480271]

Comment on attachment 8940933 [details]
Bug 1428952 - P3: Update to version 0.2.0 of AudioIPC.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211208/diff/1-2/

Comment 17

[u480271]

Comment on attachment 8940934 [details]
Bug 1428952 - P4: Vendor rust crates.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211210/diff/1-2/

Comment 18

[u480271]

Cleaned up the tokio version of audioipc suggested in #c12. Another bug landed an updated cubeb-pulse-rs so that patch has been removed from the set.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00065e245cfc
P1: Update cubeb-rs to commit aaba6b3. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/23ba5e1c773f
P2: Add update.sh for updating audioipc crates. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/5f79f72ac9fe
P3: Update to version 0.2.0 of AudioIPC. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/33873f5e18b9
P4: Vendor rust crates. r=rillian

Comment 20

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/00065e245cfc
https://hg.mozilla.org/mozilla-central/rev/23ba5e1c773f
https://hg.mozilla.org/mozilla-central/rev/5f79f72ac9fe
https://hg.mozilla.org/mozilla-central/rev/33873f5e18b9