142902 - Save as Draft or Template doesn't give out warning message when header contains chars not in the specified mail compose charset

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

Build: 05/07 branch build

When there are characters not in the specified mail compose charset, save as
draft or template should give out warning message. But now there is no warning
poped up and the characters which are not in the specified charset are displayed
question mark in the draft or template. Send Later doesn't have this problem.

Steps to reproduce:
1. Bring up mail compose window.
2. Enter something in the subject that are not in the specified mail compose
charset, for instance, with mail compose charset pointing to iso-8859-1, enter
or copy/paster Japanese characters into the subject field.
3. Select File | Save as | Draft or Template

No warning message comes up, go to draft or template folder, you can see the Ja
chars in the subject are displayed as question marks.

Comment 1

[ji]

We need this for the final release. Nominating for nsbeta1.

Comment 2

[ji]

This problem doesn't exist when body contains "illegal" chars.

Comment 3

[Frank Tang]

data lost. nsbeta1+

Comment 4

[nhottanscp]

Attachment: Moved the charset check out of "if (msgType == nsIMsgCompDeliverMode.Now || msgType == nsIMsgCompDeliverMode.Later)"

Comment 5

[nhottanscp]

same change with "diff -uw"

Index: MsgComposeCommands.js
===================================================================
RCS file:
/cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v
retrieving revision 1.266
diff -u -w -r1.266 MsgComposeCommands.js
--- MsgComposeCommands.js	10 May 2002 21:04:00 -0000	1.266
+++ MsgComposeCommands.js	14 May 2002 21:59:13 -0000
@@ -1689,6 +1689,7 @@
             break;
            default: dump("\###SendMessage Error: invalid action value\n"); return;
         }
+      }
 
         // Check if the headers of composing mail can be converted to a mail
charset.
         if (msgType == nsIMsgCompDeliverMode.Now || 
@@ -1709,7 +1710,6 @@
           if (fallbackCharset && 
               fallbackCharset.value && fallbackCharset.value != "")
             gMsgCompose.SetDocumentCharset(fallbackCharset.value);
-        }
       }
       try {
         gWindowLocked = true;

Comment 6

[Jean-Francois Ducarroz]

Comment on attachment 83600 [details] [diff] [review]
Moved the charset check out of "if (msgType == nsIMsgCompDeliverMode.Now || msgType == nsIMsgCompDeliverMode.Later)"

R=ducarroz

Comment 7

[David :Bienvenu]

Comment on attachment 83600 [details] [diff] [review]
Moved the charset check out of "if (msgType == nsIMsgCompDeliverMode.Now || msgType == nsIMsgCompDeliverMode.Later)"

sr=bienvenu

Comment 8

[nhottanscp]

checked in to the trunk

Comment 9

[Frank Tang]

can IQA verified this on the trunk ASAP.

Comment 10

[ji]

Verified as fixed with 05/16 trunk build.

Comment 11

[Frank Tang]

the patch looks really is two lines changes plus tabing changes. low risk

Comment 12

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch,pending
Driver's approval.  After, checking in, please add the fixed1.0 keyword.

Comment 13

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 83600 [details] [diff] [review]
Moved the charset check out of "if (msgType == nsIMsgCompDeliverMode.Now || msgType == nsIMsgCompDeliverMode.Later)"

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 15

[Roy Yokoyama]

patch checked into the 1.0 branch for nhotta
and change keyword to fixed1.0.1

Comment 16

[lchiang]

ji - can you verify this bug fix in 1.01 branch?  When verified, pls replace
fixed1.0.1 keyword with verified1.0.1.  Thanks.