1429021 - DBus crashes with missing profile name

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect, P1)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1420124#c21

(In reply to Tim Taubert [:ttaubert] from comment #21)
> (In reply to Martin Stránský [:stransky] from comment #20)
> > Great, Thanks. Can you also provide actual profile name you used as an
> > argument, params of
> > nsDBusRemoteService::Startup() (this is the profile name) and also the name
> > from _dbus_check_is_valid_bus_name() if that's possible. You may need to
> > install firefox debuginfo package for that.
> 
> I launched Firefox/GDB with:
> 
> > gdb --args ~/bin/firefox-nightly/firefox -profile ~/.mozilla/firefox/cp2auh9b.default
> 
> aProfileName seems empty...
> 
> > #6  0x00007fffe69eb199 in nsDBusRemoteService::Startup(char const*, char const*) (this=0x7fffc7cbf940, aAppName=0x7ffff6b89120 "firefox", aProfileName=0x7fffffffd1ac "") at /home/tim/workspace/gecko-dev/toolkit/components/remote/nsDBusRemoteService.cpp:185
> > #7  0x00007fffe69ec607 in nsRemoteService::Startup(char const*, char const*) (this=0x7fffc7cbf0d0, aAppName=0x7ffff6b89120 "firefox", aProfileName=0x7fffffffd1ac "")
> >     at /home/tim/workspace/gecko-dev/toolkit/components/remote/nsRemoteService.cpp:40
> 
> So we end up with `busName` = "org.mozilla.firefox." and the validate
> function rejects trailing dots:
> 
> https://github.com/kobolabs/dbus/blob/
> 566df92e5319a50e0a6223afccee8f1b9a03b8d5/dbus/dbus-marshal-validate.c#L1071

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1429021 - Don't try to start DBus service without any application/profile name,

Review commit: https://reviewboard.mozilla.org/r/211326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211326/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8941029 [details]
Bug 1429021 - Don't try to start DBus service without any application/profile name,

https://reviewboard.mozilla.org/r/211326/#review217744

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6f1ea151c1
Don't try to start DBus service without any application/profile name, r=jhorak

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ed6f1ea151c1