1429029 - Intermittent dom/workers/test/serviceworkers/browser_storage_permission.js | page should be controlled with storage allowed -

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: shindli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=154982432&repo=autoland

https://queue.taskcluster.net/v1/task/BOq9kgIVQXm0JltnFxXZ1A/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

How frequent is this intermittent?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I think I understand how to stop multi-e10s causing the race in the test here.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Force browser_storage_permission.js to use a single content process to avoid multi-e10s service worker propagation races. r=asuth

I looked at this previously in the --verify case.  Since the test uses separate tabs its possible that the second tab is opened in a different process from where we register the service worker.  So there is a race between the registration propagating and the second tab being loaded/controlled.

Avoid this here by just configuring for one content process.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8941158 [details] [diff] [review]
Force browser_storage_permission.js to use a single content process to avoid multi-e10s service worker propagation races. r=asuth

Review of attachment 8941158 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add an explanatory comment like:
// Until the e10s refactor is complete, use a single process to avoid propagation races.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f46aa5b6e92c
Force browser_storage_permission.js to use a single content process to avoid multi-e10s service worker propagation races. r=asuth

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f46aa5b6e92c

Comment 7

[Intermittent Failures Robot]

8 failures in 788 pushes (0.01 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 4
* autoland: 3
* mozilla-inbound: 1

Platform breakdown:
* osx-10-10: 5
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1429029&startday=2018-01-08&endday=2018-01-14&tree=all