Closed Bug 1429047 Opened 3 years ago Closed 3 years ago

Instrument Debugger's source load times

Categories

(DevTools :: Debugger, enhancement, P2)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: miker, Assigned: jdescottes)

References

(Depends on 1 open bug, )

Details

Attachments

(4 files, 1 obsolete file)

DEVTOOLS_DEBUGGER_LOAD_SOURCE: The time (in milliseconds) that it took to load a source for the user.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Target Milestone: --- → Firefox 59
To make this work we had to add the fowwlowing to DEVTOOLS_DEBUGGER_LOAD_SOURCE:

"alert_emails": ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"],
"bug_numbers": [1429047],
...
"n_buckets": 100,
Will probably come up in data review, timings usually have a _MS attached; so the probe should be named DEVTOOLS_DEBUGGER_LOAD_SOURCE_MS
TODO

Add questions from this form and get a data collection peer to review it:
https://github.com/mozilla/data-review/blob/master/request.md
Should be also fine to limit this probe to 3 releases and then reconsider if we keep it or have something better with Event Telemetry/Amplitude.
Split out bugs to track follow up telemetry work
Summary: Add telemetry probes to Debugger → Instrument Debugger's source load times
Here is an example of data review we could use for the DEVTOOLS_DEBUGGER_LOAD_SOURCE_MS (I assume we are only landing this probe for now).

Feel free to modify or discard it as you fit!

Regarding the current patch, the modification to Histograms.json from Mike's patch looks perfect, just need to set the expiry version to something like 63.
Comment on attachment 8942151 [details]
Bug 1429047 - Add telemetry probe to measure source load time;,datareview=liuche

https://reviewboard.mozilla.org/r/212414/#review218148

This looks good! thanks!
Comment on attachment 8941464 [details]
Bug 1429047 - Add telemetry probes to Debugger

https://reviewboard.mozilla.org/r/211742/#review218150

as mentioned on slack, we will do the github changes separately -- thanks mike!
Comment on attachment 8942151 [details]
Bug 1429047 - Add telemetry probe to measure source load time;,datareview=liuche

https://reviewboard.mozilla.org/r/212414/#review218152
Attachment #8942151 - Flags: review?(ystartsev) → review+
Comment on attachment 8941922 [details]
bug-1429047-data-review.md

As discussed by email, the implementation using this probe is being developed in parallel on GitHub at https://github.com/devtools-html/debugger.html/pull/4665.
Attachment #8941922 - Flags: review?(liuche)
Attachment #8941464 - Attachment is obsolete: true
Attachment #8941464 - Flags: review?(ystartsev)
Attachment #8941464 - Attachment is obsolete: true
Attachment #8941464 - Flags: review?(ystartsev)
Ignore my comment... the data request form is attached to this bug.
Flags: needinfo?(liuche)
Comment on attachment 8941922 [details]
bug-1429047-data-review.md

data-review only

> Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? (see here, here, and here for examples).

Yes, Histograms and on http://firefox-dev.tools/debugger.html/docs/local-development.html

> Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, Firefox data controls

If the request is for permanent data collection, is there someone who will monitor the data over time?**

expires in 63

> Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **

Type 1, load time

> Is the data collection request for default-on or default-off?
default on

> Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

no

> Is the data collection covered by the existing Firefox privacy notice?

yes 

    Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

expires in 66
Attachment #8941922 - Flags: review?(liuche) → review+
Julian, one question: is there separate telemetry included in https://github.com/devtools-html/debugger.html that isn't controlled by Firefox data controls? (And I assume the telemetry doesn't work if it's not in Firefox.)
Flags: needinfo?(jdescottes)
Thanks for the review!

(In reply to Chenxia Liu [:liuche] - not actively working on Fennec from comment #22)
> Julian, one question: is there separate telemetry included in
> https://github.com/devtools-html/debugger.html that isn't controlled by
> Firefox data controls? (And I assume the telemetry doesn't work if it's not
> in Firefox.)

We don't have any other telemetry setup for the debugger. When the debugger is not running in Firefox, the telemetry APIs are mocked and don't collect any data. The no-op implementation used is at https://github.com/devtools-html/devtools-core/blob/80fe5a5db96dff2bf3cc6ddb4820bb78a49367e6/packages/devtools-modules/src/Services.js#L563-L607
Flags: needinfo?(jdescottes)
(just updated the expiry in histograms.json to match version 66 mentioned in the data review)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acb786485419
Add telemetry probe to measure source load time;r=yulia,datareview=liuche
Max bucket size is 100 by default.
Assignee: mratcliffe → jdescottes
Flags: needinfo?(mratcliffe)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55b95957d30b
Add telemetry probe to measure source load time;r=yulia,datareview=liuche
https://hg.mozilla.org/mozilla-central/rev/55b95957d30b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.