Closed Bug 1429278 Opened 3 years ago Closed 3 years ago

"Zip Code" should be "ZIP Code" in address dialog in preferences

Categories

(Toolkit :: Form Autofill, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: scottwu, Assigned: dylan.turner, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

As suggested by UX & copywriter, "Zip Code" should be "ZIP Code" since it's an abbreviation of "Zone Improvement Plan".
I'm going to mentor students to work on this.

Relevant line:
* https://dxr.mozilla.org/mozilla-central/rev/8b1f0ca44c7be9a15bfbedf0cde540831f2e2aec/browser/extensions/formautofill/locales/en-US/formautofill.properties#126

I think it's fine to not change the identifier for the string in this case since it's a case-only change and it looks like many locales already varied the case: https://transvision.mozfr.org/string/?entity=browser/extensions/formautofill/formautofill.properties:zip&repo=gecko_strings
Assignee: scottcwwu → MattN+bmo
Mentor: MattN+bmo
Status: NEW → ASSIGNED
Keywords: good-first-bug
Priority: -- → P3
Attached patch 1429278.patchSplinter Review
Attachment #8944572 - Flags: review?(MattN+bmo)
Attachment #8944572 - Flags: review?(MattN+bmo) → review+
Assignee: MattN+bmo → dylan.turner
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b9b05f173b6
Change Zip Code to ZIP Code in autofill preferences. r=MattN
Keywords: checkin-needed
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a01015ef9532
Follow-up to fix test for case change. r=bustage
https://hg.mozilla.org/mozilla-central/rev/3b9b05f173b6
https://hg.mozilla.org/mozilla-central/rev/a01015ef9532
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.